1472002 - Port bug 1470910 to TB: Migrate input-box / input-box-spell to a Custom Element

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

Bug 1470910 makes it that we need to change <xul:hbox class="textbox-input-box"> to <xul:textbox-input-box class="textbox-input-box">.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: textbox-input-box.patch

I'm asking already for r? but bug 1470910 is not yet reviewed.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8988600 [details] [diff] [review]
textbox-input-box.patch

Looks like bug 1470910 is taking longer than expected. Please set r? again in due course.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: textbox-input-box.patch

Bug 1470910 is now on in m-i. They use now "moz-input-box" instead of "textbox-input-box". I found two tests which use "textbox-input-box" as anonid. I changed them and hope this works.

Comment 4

[Jorg K (CEST = GMT+2)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=b53422e1ee694f65a5586fc65eee763f04f10222
with the M-I patch applied, of course ;-)

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8997359 [details] [diff] [review]
textbox-input-box.patch

I'm not a very good XUL reviewer, perhaps Aceman can take a look before the M-C bug merges, most likely this afternoon/evening. Then we should also have the try results.

Comment 6

[Richard Marti (:Paenglab)]

It triggered bug 1480716 and it's not clear if it lands.

Comment 7

[Jorg K (CEST = GMT+2)]

We have test failures in Calendar with the M-C bug applied:

TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1533298269/build/tests/mozmill/testLocalICS.js | testLocalICS.js::testLocalICS
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1533298269/build/tests/mozmill/testTodayPane.js | testTodayPane.js::testTodayPane

Log says:
https://taskcluster-artifacts.net/ZG6dZUFmTKKRxvf8xcqP_g/0/public/logs/live_backing.log
INFO -  SUMMARY-PASS | testLocalICS.js::setupModule
INFO -  SUMMARY-PASS | testLocalICS.js::teardownTest
INFO -  SUMMARY-UNEXPECTED-FAIL | testLocalICS.js | testLocalICS.js::testLocalICS
INFO -    EXCEPTION: Expression "{"class":"textbox-input-box"}" returned null. Anonymous == true
INFO -      at: elementslib.js line 486

Also:
INFO -    EXCEPTION: menuitem is null
INFO -      at: test-calendar-utils.js line 859
INFO -         menulistSelect test-calendar-utils.js:859 5

And:
INFO -  SUMMARY-UNEXPECTED-FAIL | testTodayPane.js | testTodayPane.js::testTodayPane
INFO -    EXCEPTION: Timeout exceeded for waitForElement Lookup: id("calendar-event-dialog-inner")/id("event-grid")/id("event-grid-rows")/id("event-grid-title-row")/id("item-title")/anon({"class":"textbox-input-box"})/anon({"anonid":"input"})
INFO -      at: utils.js line 396

Richard, there is no indication that the M-C bug won't get merged.

Looks like there are heaps of textbox-input-box in Calendar.

Comment 8

[Richard Marti (:Paenglab)]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=50ee70a254bbd905f3064263c882d412f4e7b113 with a updated patch. Let's hope I found all appearances.

Comment 9

[Richard Marti (:Paenglab)]

Attachment: textbox-input-box.patch

The patch of the last try.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8997552 [details] [diff] [review]
textbox-input-box.patch

I'll have to land this when M-C next merges to fix the bustage.

Try run looks good, BTW.

Comment 11

[Jorg K (CEST = GMT+2)]

Comment on attachment 8997552 [details] [diff] [review]
textbox-input-box.patch

Thanks, rs=jorgk.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b9a01f785b98
Port bug 1470910 to TB: Migrate input-box / input-box-spell to a Custom Element. rs=jorgk

Comment 13

[:aceman]

Comment on attachment 8997552 [details] [diff] [review]
textbox-input-box.patch

Review of attachment 8997552 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this looks OK to me according to bug 1470910.