1472075 - Build UA override for Bank of America for OSX & Linux

Status: RESOLVED FIXED

(Web Compatibility :: Interventions, enhancement)

Description

[Dennis Schubert [:denschub]]

As per bug 1280834, BoA shows a warning message for Linux and Mac users, although they allow Firefox users on Windows. As per our recent discussions, let's build a site patch for that.

Comment 1

[Dennis Schubert [:denschub]]

Attachment: Pull Request #24

This PR implements the UA override as required.

Comment 2

[Dennis Schubert [:denschub]]

Comment on attachment 8988657 [details] [review]
Pull Request #24

Got an r+ from Tom on GitHub.

Comment 3

[Dennis Schubert [:denschub]]

Attachment: Unsigned XPI containing the BoA UA patch

Kavin, you mentioned on Slack that you are willing to help testing the Bank of America user agent override, to make sure the red warning is gone and nothing breaks. Is this still valid? :)

The attached XPI contains a site patch that overrides relevant navigator properties to make BoA treat Firefox for Linux and Mac as Firefox for Windows, which should remove the warning without breaking the site. Would appreciate if you'd give it a try!

Please note that this XPI is unsigned, so you need to toggle `xpinstall.signatures.required` to false to get it to install.

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

I'll attempt to get to this. I have upcoming PTO from July 6th through the 31st. So if I don't get to this by Thursday it would be best to find someone else.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

I was not able to get to this before PTO.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

I couldn't install the add-on without signing it, just by flipping the pref. After signing though, I did some testing and I couldn't spot anything wrong. If there is anything in particular that you'd like me to test, let me know!

Comment 7

[Molly Howell (she/her) (no longer active)]

I've tried the above XPI on my Mac running Nightly, and was able to confirm that the warning disappears (upon a browser restart), and that the BoA site still appears to work fine; login, accounts summary, statements, and bill pay all worked for me, and I didn't see anything out of the ordinary anywhere.

Comment 8

[Dennis Schubert [:denschub]]

Well, that was almost *perfect* timing from both of you. Thanks for testing. :)

Given that this should be a low-risk patch anyway (we're only changing from Firefox OSX to Firefox Windows), I assume this is ready. Will include that with some other patches in the next version we'll be pushing very soon.

Comment 9

[Dennis Schubert [:denschub]]

Site patch is landed in our repo on GitHub, so this can be closed. Landing the site patches (and eventually updating Release users via GoFaster) is tracked in bug 1481395.