<textarea> validity state is not preserved correctly after a clone.
Categories
(Core :: DOM: Core & HTML, defect, P2)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Keywords: topcrash)
Crash Data
Attachments
(2 files, 1 obsolete file)
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
![]() |
||
Comment 4•7 years ago
|
||
![]() |
||
Comment 5•7 years ago
|
||
Assignee | ||
Comment 6•7 years ago
|
||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Updated•7 years ago
|
Comment 11•7 years ago
|
||
Comment 12•3 years ago
|
||
The following patch is waiting for review from an inactive reviewer:
ID | Title | Author | Reviewer Status |
---|---|---|---|
D1878 | Bug 1472169: Notify of appends from CloneAndAdopt clone path. r=smaug | emilio | smaug: Resigned from review |
:emilio, could you please find another reviewer or abandon the patch if it is no longer relevant?
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•3 years ago
|
Updated•3 years ago
|
Assignee | ||
Comment 13•2 years ago
|
||
Assignee | ||
Comment 14•2 years ago
|
||
So per discussion, three approaches:
- The one in the patch. Pros: Simpler, consistent. Cons: Potentially more work / slower.
- Reuse DoneAddingChildren. We could do that by:
- Manually setting
mDoneAddingChildren = false
inCopyInnerTo
/Clone
. Pros: Potentially faster. Cons: A bit inconsistent / harder to follow. - Changing
mozilla::dom::FromParser
to something likemozilla::dom::CreationMode
. Pros: Potentially faster. Cons: More churn.
- Manually setting
I'm happy to do (1) or (2) or (3). For now let's try (1) and see what benchmarks say?
Updated•2 years ago
|
Assignee | ||
Comment 15•2 years ago
|
||
https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=2d302cfd0296475dd27a3ee3a1cc5bcf659e1a87&newProject=try&newRevision=ec95b014465c659e2c0afa936f191a09fa81c4a7 for speedometer. https://treeherder.mozilla.org/jobs?repo=try&revision=35fffbbbf0e8c73734dea11b77190a56451b11a3 for WPT.
Comment 17•2 years ago
|
||
Comment 18•2 years ago
|
||
Copying crash signatures from duplicate bugs.
Comment 19•2 years ago
|
||
The bug is linked to a topcrash signature, which matches the following criterion:
- Top 10 AArch64 and ARM crashes on nightly
:emilio, could you consider increasing the severity of this top-crash bug?
For more information, please visit BugBot documentation.
Assignee | ||
Updated•2 years ago
|
Comment 20•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 21•2 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox115
towontfix
.
For more information, please visit BugBot documentation.
Description
•