Closed Bug 1472204 Opened 7 years ago Closed 7 years ago

Inspect machine URL is broken

Categories

(Tree Management :: Treeherder: Frontend, defect, P1)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bogdan_tara, Assigned: emorley)

References

Details

(Keywords: regression)

Attachments

(3 files)

treeherder_machine_link.PNG
9.98 KB, image/png
Details
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3735
47 bytes, text/x-github-pull-request
camd
: review+
Details | Review
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3740
47 bytes, text/x-github-pull-request
Details | Review
The link under the machine id is treeherder. Attaching screenshot.
Reproduces 100% on every job i click.
Keywords: regression
Summary: link under the machine id is treeherder → link to machine id points to treeherder.mozilla.org but should be taskcluster page to manage machine
I can reproduce. This seems to be broken by the refactoring here: https://github.com/mozilla/treeherder/commit/15721f009c325256b754bd3f8ce29c16041478af#diff-46e4153312164ccdc2105111352d8741L101 ...since after `getJobMachineUrl()` was moved to the job helpers file, the argument it accepted was changed to `job`, but setJobMachineUrl() still passes `props`. It might also be good to make the link in the fallback case not link to Treeherder, to reduce confusion. I'll open a PR to temporarily fix for now.
Priority: -- → P1
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #8988745 - Flags: review?(cdawson)
Blocks: 1450022
Summary: link to machine id points to treeherder.mozilla.org but should be taskcluster page to manage machine → Inspect machine URL is broken
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/b5f0a718675fd1215b3f537a59f61a3a22ec1744 Bug 1472204 - Fix generation of job machine URL (#3735) Previously the URL was being set to the empty string, rather than: https://tools.taskcluster.net/provisioners/...
The fix has been deployed to production. Cameron - I'll leave the review open for you to double-check + I've left some questions on the PR for possible follow-ups :-)
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Comment on attachment 8988745 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3735 Also just merged a follow-up for the questions in the original PR.
Attachment #8988745 - Flags: review?(cdawson) → review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: