Closed Bug 1472241 Opened 3 years ago Closed 3 years ago

Reparent roots on startup


(Toolkit :: Places, enhancement, P2)




Tracking Status
firefox63 --- fixed


(Reporter: mak, Assigned: lina)


(Blocks 2 open bugs)


(Whiteboard: [fxsearch])


(1 file)

On startup when we read roots, we can check their parents and reparent them.
We could measure this with telemetry too.
Need to take care of Sync though.
Misparented roots are going to confuse the mirror, too, and I suspect they're causing bug 1471988. Stealing this bug. :-)
Assignee: nobody → kit
See Also: → 1453994, 1471988
This patch fixes up user content roots that aren't children of the
Places root. This patch also changes the Sync mirror to always prefer
the local root structure when merging, since the roots on the server
might be wrong.
Blocks: 1433177
Comment on attachment 8989032 [details]
Reparent Places roots on startup and handle misparented roots in the Sync mirror.

Marco Bonardo [::mak] has approved the revision.
Attachment #8989032 - Flags: review+
Pushed by
Reparent Places roots on startup and handle misparented roots in the Sync mirror. r=mak
Backout by
Backed out changeset ddb83501ed00 for xpcshell failures on test_current_from_v43. CLOSED TREE
Backed out for xpcshell failures on test_current_from_v43

Push with failures:

Failure log:

Backout link:

[task 2018-07-05T22:54:53.189Z]     INFO -  Retrying tests that failed when run in parallel.
[task 2018-07-05T22:54:53.206Z]     INFO -  TEST-START | toolkit/components/places/tests/migration/test_current_from_v43.js
[task 2018-07-05T22:54:53.592Z]  WARNING -  TEST-UNEXPECTED-FAIL | toolkit/components/places/tests/migration/test_current_from_v43.js | xpcshell return code: 0
[task 2018-07-05T22:54:53.592Z]     INFO -  TEST-INFO took 386ms
[task 2018-07-05T22:54:53.592Z]     INFO -  >>>>>>>
[task 2018-07-05T22:54:53.594Z]     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2018-07-05T22:54:53.595Z]     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2018-07-05T22:54:53.595Z]     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2018-07-05T22:54:53.596Z]     INFO -  running event loop
[task 2018-07-05T22:54:53.596Z]     INFO -  "CONSOLE_MESSAGE: (info) No chrome package registered for chrome://branding/locale/"
[task 2018-07-05T22:54:53.597Z]     INFO -  toolkit/components/places/tests/migration/test_current_from_v43.js | Starting setup
[task 2018-07-05T22:54:53.597Z]     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2018-07-05T22:54:53.597Z]     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
Flags: needinfo?(kit)
Pushed by
Reparent Places roots on startup and handle misparented roots in the Sync mirror. r=mak
Sorry about that, rebased and fixed the test. :-)
Flags: needinfo?(kit)
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Blocks: 1481795
Duplicate of this bug: 1225464
You need to log in before you can comment on or make changes to this bug.