Closed Bug 1481795 Opened 2 years ago Closed 2 years ago

Remove the maintenance task for reparenting built-in root folders

Categories

(Toolkit :: Places, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: standard8, Assigned: kajalsah, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [fxsearch][lang=js])

Attachments

(1 file)

Bug 1472241 made it so that we fix parents of the built-in root folders on startup (a much better way).

Hence we no longer need the maintenance task that was added in bug 1453994 (we should be able to back out most of that).
Basic steps:

- Look in PlacesDBUtils.jsm for the cleanup where we fix the incorrect parents and remove that section.
- Run the tests:

./mach xpcshell-test toolkit/components/places

and find the one that fails.

- Remove the code that fails.
- Rerun the test, e.g.

./mach xpcshell-test path/to/file

- Create a patch and push it to phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
-- When pushing request review from "Standard8"
Mentor: standard8
Keywords: good-first-bug
Whiteboard: [fxsearch] → [fxsearch][lang=js]
Removed extra code in PlacesDBUtils which are no longer required
Assignee: nobody → kajalksah07
Status: NEW → ASSIGNED
Attachment #9008441 - Attachment description: Removed Code in PlacesDBUtils → Remove the maintenance task for reparenting built-in root folders
Comment on attachment 9008441 [details]
Remove the maintenance task for reparenting built-in root folders

Mark Banner (:standard8) has approved the revision.
Attachment #9008441 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c22c89c9a6c2
Remove the maintenance task for reparenting built-in root folders r=Standard8
https://hg.mozilla.org/mozilla-central/rev/c22c89c9a6c2
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.