Remove the maintenance task for reparenting built-in root folders

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
11 months ago
9 months ago

People

(Reporter: standard8, Assigned: kajalsah, Mentored)

Tracking

({good-first-bug})

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [fxsearch][lang=js])

Attachments

(1 attachment)

Reporter

Description

11 months ago
Bug 1472241 made it so that we fix parents of the built-in root folders on startup (a much better way).

Hence we no longer need the maintenance task that was added in bug 1453994 (we should be able to back out most of that).
Reporter

Comment 1

10 months ago
Basic steps:

- Look in PlacesDBUtils.jsm for the cleanup where we fix the incorrect parents and remove that section.
- Run the tests:

./mach xpcshell-test toolkit/components/places

and find the one that fails.

- Remove the code that fails.
- Rerun the test, e.g.

./mach xpcshell-test path/to/file

- Create a patch and push it to phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
-- When pushing request review from "Standard8"
Mentor: standard8
Keywords: good-first-bug
Whiteboard: [fxsearch] → [fxsearch][lang=js]
Assignee

Comment 2

10 months ago
Removed extra code in PlacesDBUtils which are no longer required
Reporter

Updated

10 months ago
Assignee: nobody → kajalksah07
Status: NEW → ASSIGNED
Attachment #9008441 - Attachment description: Removed Code in PlacesDBUtils → Remove the maintenance task for reparenting built-in root folders
Reporter

Comment 3

9 months ago
Comment on attachment 9008441 [details]
Remove the maintenance task for reparenting built-in root folders

Mark Banner (:standard8) has approved the revision.
Attachment #9008441 - Flags: review+

Comment 4

9 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c22c89c9a6c2
Remove the maintenance task for reparenting built-in root folders r=Standard8

Comment 5

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c22c89c9a6c2
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.