1481795 - Remove the maintenance task for reparenting built-in root folders

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P3)

Description

[Mark Banner (:standard8)]

Bug 1472241 made it so that we fix parents of the built-in root folders on startup (a much better way).

Hence we no longer need the maintenance task that was added in bug 1453994 (we should be able to back out most of that).

Comment 1

[Mark Banner (:standard8)]

Basic steps:

- Look in PlacesDBUtils.jsm for the cleanup where we fix the incorrect parents and remove that section.
- Run the tests:

./mach xpcshell-test toolkit/components/places

and find the one that fails.

- Remove the code that fails.
- Rerun the test, e.g.

./mach xpcshell-test path/to/file

- Create a patch and push it to phabricator: https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
-- When pushing request review from "Standard8"

Comment 2

[Kajal Kumari Sah (:kajalsah)]

Attachment: Remove the maintenance task for reparenting built-in root folders

Removed extra code in PlacesDBUtils which are no longer required

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 9008441 [details]
Remove the maintenance task for reparenting built-in root folders

Mark Banner (:standard8) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c22c89c9a6c2
Remove the maintenance task for reparenting built-in root folders r=Standard8

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c22c89c9a6c2