Closed Bug 1472475 Opened Last year Closed Last year

When loading a new page in an existing tab we sometimes show the previous site's favicon for a moment or permanently

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + verified

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: regression)

Attachments

(1 file)

1. Load a page with a favicon.
2. Load a new page with a different favicon.

After the loading throbber stops you'll briefly see site 1's favicon before site 2's is loaded. If site 2 does not have a favicon at all we will probably continue to show site 1's.
[Tracking Requested - why for this release]:
In practice this is an easy fix, just clear the icon when the page first changes
to a new URL. In practice that breaks our hack for setting an early favicon for
certain in-content pages so we have to workaround that somewhat.
Comment on attachment 8989084 [details]
Bug 1472475: Properly clear the current favicon when navigating to a new URL.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1909
Attachment #8989084 - Flags: review+
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/25344c934be3
Properly clear the current favicon when navigating to a new URL. r=mak
Summary: When loading a new page in an existing tab we sometimes show the previous site's favicon for a moment → When loading a new page in an existing tab we sometimes show the previous site's favicon for a moment or permanently
https://hg.mozilla.org/mozilla-central/rev/25344c934be3
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
I have reproduced this bug with Nightly 63.0a1 (2018-06-30) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180704100142
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180704]
Depends on: 1483492
Flags: qe-verify+
I have managed to reproduce this issue using Firefox 63.0a1 (BuildId:20180630220240) on Windows 10 64bit.

This issue is verified fixed using Firefox 63.0b7 (BuildId:20180917143811) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1508603
You need to log in before you can comment on or make changes to this bug.