1472475 - When loading a new page in an existing tab we sometimes show the previous site's favicon for a moment or permanently

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dave Townsend [:mossop]]

1. Load a page with a favicon.
2. Load a new page with a different favicon.

After the loading throbber stops you'll briefly see site 1's favicon before site 2's is loaded. If site 2 does not have a favicon at all we will probably continue to show site 1's.

Comment 1

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1472475: Properly clear the current favicon when navigating to a new URL.

In practice this is an easy fix, just clear the icon when the page first changes
to a new URL. In practice that breaks our hack for setting an early favicon for
certain in-content pages so we have to workaround that somewhat.

Comment 3

[Phabricator Automation]

Comment on attachment 8989084 [details]
Bug 1472475: Properly clear the current favicon when navigating to a new URL.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D1909

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25344c934be3
Properly clear the current favicon when navigating to a new URL. r=mak

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/25344c934be3

Comment 6

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 63.0a1 (2018-06-30) on Windows 10, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20180704100142
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Comment 7

[Emil Ghitta, QA [:emilghitta]]

I have managed to reproduce this issue using Firefox 63.0a1 (BuildId:20180630220240) on Windows 10 64bit.

This issue is verified fixed using Firefox 63.0b7 (BuildId:20180917143811) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 16.04 64bit.