Closed Bug 1472921 Opened 6 years ago Closed 6 years ago

New performance panel cannot save sampling interval value that is less than 1 ms

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

63 Branch
defect

Tracking

(firefox61 wontfix, firefox62 wontfix, firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: m_kato, Assigned: past)

References

Details

Attachments

(1 file)

Step
1. Enable new performance panel
2. Open Performance from devtool menu
3. Set sampling interval to 0.1 ms
4. Close devtool
5. Open devtool, then open performance panel

Result
Sampling interval is 0ms

Expected Result
Sampling interval sets 0.1 ms (that is same value as step 3)

Notes
If this interval is equal or greater than 1ms, it works well.
Char sounds good to me.
Priority: -- → P1
I went with an int pref to simplify things (msec -> usec). In particular I'm not sure if you can change the type of a pref right after reading it without throwing. Let me know if you'd rather have the more complicated migration step.
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment on attachment 8995126 [details]
Bug 1472921 - Fix sampling interval persistence for values <1ms.

https://reviewboard.mozilla.org/r/259602/#review267044

You also need to change the default value in [1], otherwise the default is 0.001ms :) Otherwise I think this is good to go! Thanks a lot for this :)

[1] https://searchfox.org/mozilla-central/rev/d47c829065767b6f36d29303d650bffb7c4f94a3/devtools/client/performance-new/store/reducers.js#61
Attachment #8995126 - Flags: review?(felash) → review+
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0a485a8db67c
Fix sampling interval persistence for values <1ms. r=julienw
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfc3d5482f79
Backed out changeset 0a485a8db67c for debug-mochitest-chrome failures on test_perf-settings-interval.html
Forgot to rerun the tests after the one line change!
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/230936a14d39
Fix sampling interval persistence for values <1ms. r=julienw
https://hg.mozilla.org/mozilla-central/rev/230936a14d39
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: