1473142 - Set browser.startup.blankWindow to true on Windows and let it ride out to release

Status: RESOLVED FIXED

(Firefox :: General, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

We've got alignment from UX / UR on this, and Product has given us the go ahead to ship the first-blank-paint feature as it currently stands in Nightly on Windows.

Let's flip the pref to let this thing ride out.

At the very least, this should go out in 63 - but I'm going to see if we can get it into 62 (since it's early in the cycle, and this is very low risk).

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey florian, are you willing to write a patch for this? I'll happily review it.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

This is a straight backout of bug 1465583.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8989742 [details] [diff] [review]
Patch

Review of attachment 8989742 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +254,2 @@
>  // Disabled on Mac because the bouncing dock icon already provides feedback.
> +#if defined(XP_WIN) || defined(MOZ_WIDGET_GTK) && defined(EARLY_BETA_OR_EARLIER)

This also enables the feature for Linux up until early beta. Is there still value in doing this?

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

Keep this nightly-only for Linux until we fix bug 1450626.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4171061dc9e
Set browser.startup.blankWindow to true on Windows (ie. backout bug 1465583), r=mconley.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c4171061dc9e

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 8989760 [details] [diff] [review]
Patch v2

Approval Request Comment
[Feature/Bug causing the regression]: The feature landed in bug 1336227 pref'ed off. We were planning to ship it in the 61 train (bug 1447719), but it got disabled late in the 61 cycle in bug 1465583 to give more time for a UR study to be completed. We now have the results of the study, and thus decided to ship it.
[User impact if declined]: slower perception of startup on Windows.
[Is this code covered by automated tests?]: no.
[Has the fix been verified in Nightly?]: yes.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk.
[Why is the change risky/not risky?]: this baked on Nightly for several trains, and was enabled on beta for most of the 61 cycle.
[String changes made/needed]: none.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8989760 [details] [diff] [review]
Patch v2

Seems very reasonable, let's uplift for beta 7. 
Thanks for giving all the background!

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ab4de937c2d2