Closed
Bug 1473210
Opened 6 years ago
Closed 6 years ago
Add tests for meatball menu
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: birtles, Assigned: mantaroh)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
See bug 1461522 comment 151. We can probably at least do some tests for the keyboard handling.
Reporter | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•6 years ago
|
||
I'm going to add the test which related with the MenuButton(e.g., shortcut keys, see bug 1477367).
I'll add the function key test and the arrow key test as well.
Brian,
What kind of tests do you think need to add?
Assignee: nobody → mantaroh
Status: NEW → ASSIGNED
Flags: needinfo?(bbirtles)
Assignee | ||
Comment 2•6 years ago
|
||
OK. I added sanity meatball tests:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab2bc3dbd23334eef6c4bed3b82ed5388537c48a
Flags: needinfo?(bbirtles)
Assignee | ||
Comment 3•6 years ago
|
||
This test will check the following:
* Open / Close the meatball menu with click the button.
* Handling the keys. (Up / Down / Home / End)
* Close the meatball menu with F1 key.
* Close the meatball menu with Escape key.
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 9001907 [details]
Bug 1473210 - Add meatball menu sanity tests. r?birtles
Brian Birtles (:birtles) has approved the revision.
Attachment #9001907 -
Flags: review+
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d8fc943845d6
Add meatball menu sanity tests. r=birtles
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•