1473356 - Script the creation of a WNP blob (schema 9)

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Manual steps are documented at: https://github.com/mozilla-releng/releasewarrior-2.0/blob/master/docs/release-promotion/desktop/howto-rc.md#wnp

Callek had scripted the old way of doing WNP. Let's update these scripts to let it do it for us.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: [mozilla-version] PR: Add support for balrog release names

I'm updating the script, and I'd like to make the script default to the previous release. To do so, mozilla-version should extract versions from a release name like "Firefox-60.0-build3". What do you think, Tom?

Comment 2

[Tom Prince [:tomprince]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #1)
> To do so, mozilla-version should extract versions from a
> release name like "Firefox-60.0-build3". What do you think, Tom?

I think mozilla-version should be able to extract a name from a release identifier like that *if* you ask to, but not when you just ask it to parse a version number.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/braindump] Update create_wnp_blob.py to support new balrog schema

This probably requires some changes after we changed the API of mozilla-version, but the algorithm should be about the same.

I'm also feeling less comfortable having this live in braindump because of the lack of automated testing. I only manually tested it :jlund, do you think this can live in releasewarrior-2.0?

Comment 4

[Jordan Lund (:jlund)]

(In reply to Johan Lorenzo [:jlorenzo] from comment #3)
> I'm also feeling less comfortable having this live in braindump because of
> the lack of automated testing. I only manually tested it :jlund, do you
> think this can live in releasewarrior-2.0?

Please, yes let's use rw/scripts/. I imagine it was only in braindump initially as callek was using it as a personal tool and wanted to share it. Much like all braindump things. But now it's probably right for it to graduate :)

Comment 5

[Justin Wood (:Callek)]

Comment on attachment 8990272 [details] [diff] [review]
[build/braindump] Update create_wnp_blob.py to support new balrog schema

Review of attachment 8990272 [details] [diff] [review]:
-----------------------------------------------------------------

I did write the original stuff here, but I know little about the Schema 9, and I haven't yet investigated mozilla-version all that well, so I'm tossing this over to tom who's already flagged in this bug (and is releaseduty).

Comment 6

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8990272 [details] [diff] [review]
[build/braindump] Update create_wnp_blob.py to support new balrog schema

There was a WNP request today. I used that script to generate it. I seize this occasion to move the script to releasewarrior.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8989941 [details] [review]
[mozilla-version] PR: Add support for balrog release names

Was r+'d by Tom at https://github.com/mozilla-releng/mozilla-version/pull/5#pullrequestreview-145046422
Released as part of mozilla-version 0.2.0

Comment 8

[Johan Lorenzo [:jlorenzo]]

Attachment: [releasewarrior-2.0] Script the creation of a WNP blob (schema 9)

This PR automates the creation of the blog locally. Yesterday, Mihai, Tom, and I thought of a way of implementing this in-tree. I'll file a follow up bug for this.

In the meantime, I suggest we use this script. An early revision of it helped me publish the 61.0.2 blob.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8999141 [details] [review]
[releasewarrior-2.0] Script the creation of a WNP blob (schema 9)

https://github.com/mozilla-releng/releasewarrior-2.0/commit/6dda01c729647b5b80fa085ced87a6273307d236