1499632 - why diff between Firefox-63.0-build1-No-WNP and Firefox-63.0-build1 removes the releasenotes link?

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Rok Garbas [:garbas]]

actual diff between Firefox-63.0-build1-No-WNP and Firefox-63.0-build1 is here: http://paste.debian.net/hidden/2d269340/

Comment 1

[Rok Garbas [:garbas]]

a snippet from #mozbuild discussion:

│10:07:32  jlorenzo │ damn, it's the Google Play support again :|
│10:11:42    garbas │ morning, anybody more familiar with WNP then me around? any idea why http://paste.debian.net/hidden/2d269340/ (diff between
│                   │ Firefox-63.0-build1-No-WNP and Firefox-63.0-build1) removes the releasenotes link?
│10:13:48   sfraser │ hmm, not sure. was it manually added to the first link?
│10:14:47  jlorenzo │ or was it generated with https://hg.mozilla.org/build/braindump/file/tip/releases-related/create_wnp_blob.py ?
│10:16:27         ¬ │ oh that link is outdated actually
│10:16:42         ¬ │ was it generated with releasewarrior's wnp_blob?
│10:16:43  @nthomas │ yeah, script needs updating
│10:17:04  jlorenzo │ I should have deleted it in bug 1473356
│10:18:54    garbas │ jlorenzo: sorry i'm not sure which link do you mean is outdated
│10:19:17  jlorenzo │ I'm sorry,  this one  https://hg.mozilla.org/build/braindump/file/tip/releases-related/create_wnp_blob.py
│10:19:52    garbas │ i see, we use rw now to generate this wnp blobs, correct?
│10:19:59  jlorenzo │ that's right
│10:20:35  @nthomas │ I don't think that braindump script could have generated the current blob though
│10:20:52  jlorenzo │ that's right too
│10:21:11         ⚡ │ nthomas looks in the balrog history
│10:22:32  @nthomas │ we'd have to ask a.ki
│10:23:06         ¬ │ likely just a whoopsie
│10:23:41  jlorenzo │ what does the releasenote link do? when is it triggered?
│10:23:59  @nthomas │ we should put the detailsURL block back, it shows up as 'Details' in some the update UI
│10:26:13  jlorenzo │ to me it's a bug in releasewarrior. I probably introduced it
│10:26:30         ¬ │ so, I'm wondering under which circumstances `detailsURL` is interpreted by Firefox?
│10:27:00  @nthomas │ it should be present in every update.xml
│10:27:29  jlorenzo │ okay, we probably shipped 2 major versions without it, IIUC
│10:28:06  @nthomas │ these days it shows up if you go to About > Firefox and click on "What's new" when an update is pending, and probably in the UI that
│                   │ prompts you after having an update ready to apply for ages
│10:28:20         ¬ │ it's not very prominent, at least compared to older update UI
│10:28:31  jlorenzo │ okay
│10:28:53  @nthomas │ Firefox-62.0-build1 looks ok
│10:29:18         ¬ │ so does 62.0.3, looks like QE caught a real thing
│10:34:13  jlorenzo │ okay I wonder how it used to work
│10:34:43  @nthomas │ how long ago ?
│10:35:37  jlorenzo │ when I started to roll `release wnp_blob` out. I see all 62.0 releases are sane, I remember changing some of them with that script
│10:35:48         ¬ │ bug is in this function: https://github.com/mozilla-releng/releasewarrior-2.0/blob/master/releasewarrior/balrog.py#L65
│10:36:10         ¬ │ it doesn't copy all exiting entries in updateLines
│10:36:22  @nthomas │ my quick read of that was that it'd leave non-wnp things alone
│10:39:09  jlorenzo │ yeah it should. pdb tells me it doesn't :/
│10:39:09  @nthomas │ https://github.com/mozilla-releng/releasewarrior-2.0/blob/master/docs/release-promotion/desktop/howto-rc.md#wnp is wrong in the sense
│                   │ that it talks about appending info, but the example removes the detailsUrl block

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: [releasewarrior-2.0] Update WNP instructions to use `release wnp_blob`

I initially thought it was a bug in `release wnp_blob`, but after some debugging, it does keep the releasenotes in the blob. Therefore, Nick and I think it was updated manually with some ambiguous documentation[1]. This patch updates the docs.

In the meantime, I just fixed the blob and it went live about 2 minutes ago thanks to Pascal's signoff. 

[1] https://github.com/mozilla-releng/releasewarrior-2.0/blob/de44b182a0e3e6c01b49da52e3e2371e60f2055f/docs/release-promotion/desktop/howto-rc.md#wnp

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: [build/braindump] Remove outdated wnp scripts

While tracing back the script, I realized this old version of the script isn't needed anymore. `create_wnp_blob.py` did the same thing as `release wnp_blob`, but it's now outdated. `create_win64_migration_blob.py` is outdated as well and won't be used anymore because the Product team decided to not migrate ESR users on win32 to win64. Therefore, there is no channel to update anymore.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9017837 [details] [diff] [review]
[build/braindump] Remove outdated wnp scripts

https://hg.mozilla.org/build/braindump/rev/4e4fcc1dbbd024cce22bbb085c0d6c316ad7b91e

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9017835 [details] [review]
[releasewarrior-2.0] Update WNP instructions to use `release wnp_blob`

https://github.com/mozilla-releng/releasewarrior-2.0/commit/804ec4d7ab32a4e1df72648339370cdc27286a98

Comment 6

[Johan Lorenzo [:jlorenzo]]

Documentation updated. To me, the real fix would be bug 1482395. I hope the documentation will be less error-prone :)