1473397 - Add Haptic Feedback support to gfxVRExternal and VRSessionOpenVR

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Comment 1

[:kip (Kearwood Gilbert)]

Attachment: Bug 1473397 - Implement haptic feedback support for gfxVRExternal and OpenVRSession - Implemented 1ms, 10ms, and 100ms VR tasks, dispatched from VRManager - Removed Android-specific code that compensated for tasks that did not run when the...

...compositor was paused.

Comment 2

[Daosheng Mu[:daoshengmu]]

Comment on attachment 9000124 [details]
Bug 1473397 - Implement haptic feedback support for gfxVRExternal and OpenVRSession
- Implemented 1ms, 10ms, and 100ms VR tasks, dispatched from
  VRManager
- Removed Android-specific code that compensated for
  tasks that did not run when the...

Daosheng Mu[:daoshengmu] has approved the revision.

Comment 3

[:kip (Kearwood Gilbert)]

I have rolled in some fixes to intermittent test failures and some of our thread safety issues into this patchset.  They were causing many try failures with the changes I was introducing for scheduling sub-frame tasks.


Handy link for diff for the patch revision since the one you reviewed earlier:
https://phabricator.services.mozilla.com/D3378?vs=12268&id=15649&whitespace=ignore-most#toc

I've kicked off a new try run to see if it clears up now.  This may also help with the other crash related bugs we are seeing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f322ac315789b355a42b4455892f66e05c90333a

Comment 4

[:kip (Kearwood Gilbert)]

Last try push revealed memory leaks.  I've updated the patch and pushed again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f18107a28e84f1ad96c2ab9bb16d6fccf6f9f4ee

Comment 5

[:kip (Kearwood Gilbert)]

I have updated the puppet test code to better handle the now asynchronous creation of puppet controllers, which should hopefully fix the last test failure that is still blocking this from landing.

I've pushed to try to verify that it's fixed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d029e1239116cf50d7b9197207e72d4435d557b

Comment 6

[:kip (Kearwood Gilbert)]

Although tests passed locally, it appears that we still need to generate vsync for headless mochitests running on the try server.  I've updated the patch and pushed to try again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8693c0b0aa73f1764bd519c75ef99b1dc6a50363

Comment 7

[:kip (Kearwood Gilbert)]

I have updated the patch to disable the intermittent mochitests in dom/vr/test/mochitest which were failing all the time with this patch applied.  They will be fixed properly and re-enabled as part of the refactoring for gfxVRPuppet in Bug 1466702
(Refactor gfxVRPuppet.cpp to use gfxVRExternal interface).

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49f48ff493c6
Implement haptic feedback support for gfxVRExternal and OpenVRSession r=daoshengmu

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/49f48ff493c6