Closed Bug 1473397 Opened 2 years ago Closed Last year

Add Haptic Feedback support to gfxVRExternal and VRSessionOpenVR

Categories

(Core :: WebVR, enhancement)

59 Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: kip, Assigned: kip)

References

Details

Attachments

(1 file)

No description provided.
Blocks: 1473399
Comment on attachment 9000124 [details]
Bug 1473397 - Implement haptic feedback support for gfxVRExternal and OpenVRSession
- Implemented 1ms, 10ms, and 100ms VR tasks, dispatched from
  VRManager
- Removed Android-specific code that compensated for
  tasks that did not run when the...

Daosheng Mu[:daoshengmu] has approved the revision.
Attachment #9000124 - Flags: review+
I have rolled in some fixes to intermittent test failures and some of our thread safety issues into this patchset.  They were causing many try failures with the changes I was introducing for scheduling sub-frame tasks.


Handy link for diff for the patch revision since the one you reviewed earlier:
https://phabricator.services.mozilla.com/D3378?vs=12268&id=15649&whitespace=ignore-most#toc

I've kicked off a new try run to see if it clears up now.  This may also help with the other crash related bugs we are seeing:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f322ac315789b355a42b4455892f66e05c90333a
Last try push revealed memory leaks.  I've updated the patch and pushed again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f18107a28e84f1ad96c2ab9bb16d6fccf6f9f4ee
I have updated the puppet test code to better handle the now asynchronous creation of puppet controllers, which should hopefully fix the last test failure that is still blocking this from landing.

I've pushed to try to verify that it's fixed:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d029e1239116cf50d7b9197207e72d4435d557b
Although tests passed locally, it appears that we still need to generate vsync for headless mochitests running on the try server.  I've updated the patch and pushed to try again:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8693c0b0aa73f1764bd519c75ef99b1dc6a50363
I have updated the patch to disable the intermittent mochitests in dom/vr/test/mochitest which were failing all the time with this patch applied.  They will be fixed properly and re-enabled as part of the refactoring for gfxVRPuppet in Bug 1466702
(Refactor gfxVRPuppet.cpp to use gfxVRExternal interface).
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49f48ff493c6
Implement haptic feedback support for gfxVRExternal and OpenVRSession r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/49f48ff493c6
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Depends on: 1494490
Depends on: 1494556
You need to log in before you can comment on or make changes to this bug.