1473399 - Enable VRService thread by default

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[:kip (Kearwood Gilbert)]

Once the VRService thread (gfx/vr/service/VRService.cpp) is able to replicate all functionality implemented in gfxVROculus, gfxVROpenVR, gfxVRPuppet, and gfxVROSVR, we can enable the VR service thread by default.

Flipping the dom.vr.service.enabled thread will both enable the VR service thread and disable the gfxVROculus, gfxVROpenVR, and gfxVROSVR implementations.

Comment 1

[:kip (Kearwood Gilbert)]

Removing dependencies:

Bug 1466701 (Refactor gfxVROSVR.cpp to use gfxVRExternal interface)

Bug 1466702 (Refactor gfxVRPuppet.cpp to use gfxVRExternal interface)

OSVR is not enabled by default and should not block enabling the service thread.  OSVR users can simply flip both prefs to activate OSVR until the OSVR related refactoring is complete.

The Puppet VR device can remain as it is and later be refactored to reside in the VR Service process.  Unlike the other VR devices, the Puppet VR device communicates with no physical hardware / drivers and will not block any of our sandboxing efforts.

Comment 2

[:kip (Kearwood Gilbert)]

Try push combining Bug 1466700 (Refactor gfxVROculus.cpp to use gfxVRExternal interface) and dom.vr.service.enabled pref flip:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7076f49cf81ab7e98e48935a45acca372737da3

Comment 3

[:kip (Kearwood Gilbert)]

Attachment: Bug 1473399 - Enable VR Service thread by default

Comment 4

[:kip (Kearwood Gilbert)]

Updated Bug 1466700 patch to fix #ifdef broken during merge.  Updated combined try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8560e3af4a7a07c31d6d875226a3d270fdf69234

Comment 5

[:kip (Kearwood Gilbert)]

Bug 1466700 patch updated again.  New combined try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3578697b40cb61945a8f08ac46633fc63e3110ab

Comment 6

[:kip (Kearwood Gilbert)]

bug 1466700 patch update, new try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e0372a7ca455c3cafd557d3391af92526a7efd3

Comment 7

[:kip (Kearwood Gilbert)]

bug 1466700 patch updated again, to fix assertion found in Comment 6 try push, new try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b7f4308c5e75f6014f39d26045d3b126c7143d3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81c3640eaebc
Enable VR Service thread by default,r=daoshengmu

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/81c3640eaebc

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbfaee2b2770
Backed out changeset 81c3640eaebc for causing build bustage on /build/build/src/gfx/vr/service/OculusSession.cpp

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Sorry Kip, this had the misfortune of landing right around the same time that MSVC builds got bumped back up to Tier 1. See bug 1498550 for the bustage they were hitting.

Comment 12

[:kip (Kearwood Gilbert)]

Once Bug 1466700 is re-landed, then this can be re-landed also.  This patch shouldn't need any modifications as it is just flipping the prefs.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60a3ffcd4f7e
Enable VR Service thread by default. r=daoshengmu

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/60a3ffcd4f7e