Enable VRService thread by default

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
Last year
10 months ago

People

(Reporter: kip, Assigned: kip)

Tracking

59 Branch
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

Once the VRService thread (gfx/vr/service/VRService.cpp) is able to replicate all functionality implemented in gfxVROculus, gfxVROpenVR, gfxVRPuppet, and gfxVROSVR, we can enable the VR service thread by default.

Flipping the dom.vr.service.enabled thread will both enable the VR service thread and disable the gfxVROculus, gfxVROpenVR, and gfxVROSVR implementations.
Blocks: 1362578
Depends on: 1466701, 1466702
Blocks: 1473401
See Also: → 1430038
Blocks: 1476092
Removing dependencies:

Bug 1466701 (Refactor gfxVROSVR.cpp to use gfxVRExternal interface)

Bug 1466702 (Refactor gfxVRPuppet.cpp to use gfxVRExternal interface)

OSVR is not enabled by default and should not block enabling the service thread.  OSVR users can simply flip both prefs to activate OSVR until the OSVR related refactoring is complete.

The Puppet VR device can remain as it is and later be refactored to reside in the VR Service process.  Unlike the other VR devices, the Puppet VR device communicates with no physical hardware / drivers and will not block any of our sandboxing efforts.
No longer depends on: 1466701, 1466702
Try push combining Bug 1466700 (Refactor gfxVROculus.cpp to use gfxVRExternal interface) and dom.vr.service.enabled pref flip:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7076f49cf81ab7e98e48935a45acca372737da3
Updated Bug 1466700 patch to fix #ifdef broken during merge.  Updated combined try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8560e3af4a7a07c31d6d875226a3d270fdf69234
bug 1466700 patch updated again, to fix assertion found in Comment 6 try push, new try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b7f4308c5e75f6014f39d26045d3b126c7143d3
Pushed by kgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/81c3640eaebc
Enable VR Service thread by default,r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/81c3640eaebc
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Backout by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bbfaee2b2770
Backed out changeset 81c3640eaebc for causing build bustage on /build/build/src/gfx/vr/service/OculusSession.cpp
Sorry Kip, this had the misfortune of landing right around the same time that MSVC builds got bumped back up to Tier 1. See bug 1498550 for the bustage they were hitting.
Status: RESOLVED → REOPENED
Flags: needinfo?(kgilbert)
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Depends on: 1498550
Once Bug 1466700 is re-landed, then this can be re-landed also.  This patch shouldn't need any modifications as it is just flipping the prefs.
Flags: needinfo?(kgilbert) → needinfo?(ryanvm)
Flags: needinfo?(ryanvm)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/60a3ffcd4f7e
Enable VR Service thread by default. r=daoshengmu
https://hg.mozilla.org/mozilla-central/rev/60a3ffcd4f7e
Status: REOPENED → RESOLVED
Closed: 10 months ago10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.