Firefox can not remove the extension XPI from OS temporary folder
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
People
(Reporter: CoolCmd, Assigned: rpl)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Comment 2•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 6•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 7•7 years ago
|
||
Comment 8•7 years ago
|
||
Assignee | ||
Comment 9•7 years ago
|
||
Comment 10•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Assignee | ||
Comment 11•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 12•6 years ago
|
||
Comment 13•6 years ago
|
||
bugherder |
Comment 14•6 years ago
|
||
Verified the fix using the latest Nightly (70.0a1/20190821215524) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.
The warning message is no longer displayed in the browser console and the temporary XPI is deleted from the temp folder immediately after the extension is installed in the browser, thus confirming the fix.
Assignee | ||
Comment 15•6 years ago
|
||
Comment on attachment 9084271 [details]
Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it.
Beta/Release Uplift Approval Request
- User impact if declined: Firefox doesn't remove the temporary xpi files related to the extensions installed by the user. These temporary files cannot even be removed manually by the user while the Firefox instance that has created them is still running.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: Same steps used to verify the fix on Nightly (as described by the reporter in comment 0).
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): One line change (which just makes sure that the jar cache for the temporary xpi file is flushed right before trying to remove it).
- String changes made/needed:
Assignee | ||
Updated•6 years ago
|
Comment 16•6 years ago
|
||
Comment on attachment 9084271 [details]
Bug 1473837 - AddonInstall should flush the jar cache for the temporary xpi file before trying to remove it.
Simple fix to allow temporary XPIs to be removed. Approved for 69.0b16.
Comment 17•6 years ago
|
||
bugherder uplift |
Updated•6 years ago
|
Comment 18•6 years ago
|
||
Verified the fix using the latest Beta (69.0b16/20190822210915) under Windows 10 Pro 64-bit and macOS High Sierra 10.13.6.
The warning message is no longer displayed in the browser console and the temporary XPI is deleted from the temp folder immediately after the extension is installed in the browser, thus confirming the fix.
Updated•6 years ago
|
Comment 21•5 years ago
|
||
I'm still seeing fresh tmp-*.xpi files in temp that are not being deleted on Linux in fresh versions: it's at least 75 through 76.0.1 but I have the folder in tmpfs so it's possible it never stopped. Should I reopen this report or start a new one?
Comment 22•5 years ago
|
||
Hello,
I’ve rechecked the issue and when installing add-ons from AMO, all tmp-*.xpis are properly deleted from the generic temp folders upon the install completing, no errors being shown in the browser console either. I’ve rechecked on the latest Nightly (78.0a1/20200518214824), Beta (77.0b7/20200515125749) and Release (76.0.1/20200507114007) under Windows 10 Pro 64-bit, macOS Catalina 10.15 and Ubuntu 16.04.
In what concerns the tmpfs file system on Linux, it is beyond my technical knowledge and could not check there.
However, while investigating the current issue, I’ve come across a bug which might explain the behavior you have encountered (i.e tmp-*.xpi files not being deleted from temp folders). Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1639163 for further details.
Comment 23•5 years ago
|
||
Thank you! I forgot to specify that it happens on add-on upgrades. I don't think tmpfs is the reason, I cannot imagine how that would affect things. I guess #1639163 covers this issue too anyway.
Comment 24•5 years ago
|
||
Hi Сергій,
I just checked what you said about add-on upgrades and still cannot reproduce the issue.
I attempted to reproduce on the latest Nightly, Beta and Release on Windows 10 Pro 64-bit and Ubuntu 16.04 LTS with uBlock Origin, Ghostery and Decentraleyes.
Indeed a tmp-*.xpi file is created as soon as the add-on update process begins, but it’s deleted once the add-on is updated.
Note: After installing an older version of the mentioned add-ons, I’ve manually checked for add-on updates via “Check for Updates” from the cog wheel menu.
Assignee | ||
Comment 25•5 years ago
|
||
(In reply to Сергій from comment #23)
Thank you! I forgot to specify that it happens on add-on upgrades. I don't think tmpfs is the reason, I cannot imagine how that would affect things. I guess #1639163 covers this issue too anyway.
I'm wondering if the tmp-*.xpi files not being removed may be related to "postponed addon upgrades".
would you mind to try to reproduce the issue and then collect and send me a small sample of the tmp-*.xpi files?
I'd like to double-check if it may be the same underlying issue that the patch attached to Bug 1495021 is meant to fix.
Comment 26•5 years ago
|
||
Yes, I have two files currently, 2.8MiB each. Sending them to your e-mail. Unless you meant changing some settings and then waiting for them to appear.
Comment 27•5 years ago
|
||
GMail didn't like it at all. Any other way I can send them or can I just open them and give you some short text info?
Assignee | ||
Comment 28•5 years ago
|
||
(In reply to Сергій from comment #27)
GMail didn't like it at all. Any other way I can send them or can I just open them and give you some short text info?
Send me just the manifest.json files, that may be enough to let me identify which extensions the xpi files are related to.
Thanks a lot!
Comment 29•5 years ago
|
||
Sent them, it's uBlock Origin 1.27.2 and 1.27.0
Assignee | ||
Comment 30•5 years ago
|
||
Thanks for collecting and sending the manifest files to me.
Yeah, both the xpi files are related to "uBlock origin", and so I can now confirm that the issue you are experiencing is related to the "postponed add-on upgrades" as I was initially assuming (uBlock origin is one of the few extension that is using a post-poned upgrade, and so it is triggering this issue).
The issue with the temporary file should be fixed by the patch attached to Bug 1495021, while a more visible feedback (and fix) for the postponed upgrades is going to be part of Bug 1627495.
You can follow those two bugs to be notified by bugzilla once we will land the patch to fix them.
Thanks again for your help on investigating this.
Description
•