1639163 - Temporary .xpis are not deleted from the temp folder if canceling the add-on AMO install

Status: NEW

(Toolkit :: Add-ons Manager, defect, P3)

Description

[Alex Cornestean]

Attachment: tmp xpi not deleted.gif

[Affected versions]:

• 78.0a1/20200518214824
• 77.0b7/20200515125749
• 76.0.1/20200507114007

[Affected platforms]:

• Windows 10 Pro 64-bit
• Ubuntu 16.04 LTS
• macOS Catalina 10.15

[Prerequisites]:
Make sure to open the temp folder of each specific OS in order to see the issue occuring.

[Steps to reproduce]:

1. Go to AMO and access any add-on page
2. Click on the “+Add to Firefox” button to install the add-on
3. Notice that in the temp folder a tmp*.xpi file will be created
4. On the add-on install doorhanger choose “Cancel” to abort the installation processe
5. Notice that in the temp folder, the tmp*.xpi file created earlier will not be deleted

[Expected results]:
Interrupting the AMO install process of add-ons should still delete temporary .xpi files from the temp folder.

[Actual results]:
Temporary .xpi files created during the add-on AMO installation are not deleted when canceling the install.

In the attached video you can see that the second tmp.xpi will disappear as a result of me completing the add-on installation, however, the first tmp.xpi will remain as I canceled the installation.

Comment 1

[Serhiy]

May be related: tmp-*.xpi files are also not deleted after upgrading add-ons. uBlock Origin is frequently updates these days, noticed because of it.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mixedpuppy, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Shane Caraveo (:mixedpuppy)]

May be related to bug 1495021