Closed
Bug 1473921
Opened 7 years ago
Closed 7 years ago
Load "checkbox.css" and "radio.css" as document stylesheets
Categories
(Toolkit :: Themes, enhancement, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: Paolo, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
|
7.27 KB,
patch
|
Paolo
:
review+
|
Details | Diff | Splinter Review |
This is part of the work tracked in bug 1470830.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8990336 [details]
Bug 1473921 - Load "checkbox.css" and "radio.css" as document stylesheets.
https://reviewboard.mozilla.org/r/255372/#review262214
Attachment #8990336 -
Flags: review?(bgrinstead) → review+
| Comment hidden (mozreview-request) |
This needs to be moved to Phabricator.
Flags: needinfo?(paolo.mozmail)
|
Reporter | |
Comment 5•7 years ago
|
||
Yes, links to the patch set are in bug 1470830 comment 1.
Flags: needinfo?(paolo.mozmail)
|
|
Reporter | |
Comment 6•7 years ago
|
||
Hi Dão, Mike mentioned that you were going to tackle some of these stylesheet conversions. Talking with the XBL removal team, this bug is one of the most useful right now, because the associated binding is close to being able to be removed. Do you have time for helping with the conversion?
Flags: needinfo?(dao+bmo)
|
Assignee | |
Comment 7•7 years ago
|
||
I can look into it. Was there a specific problem with this patch? Why was it not landed when it got r+?
Flags: needinfo?(dao+bmo) → needinfo?(paolo.mozmail)
|
|
Reporter | |
Comment 8•7 years ago
|
||
Thanks! This was only a stub patch (<https://hg.mozilla.org/mozreview/gecko/rev/836129fe1fc1>), and it was rubber-stamped when we originally planned to land everything in one batch and fix issues later. I'm not already aware of any problems, but we may have specificity issues similar to the other patches we landed.
Flags: needinfo?(paolo.mozmail)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → dao+bmo
|
|
Assignee | |
Comment 9•7 years ago
|
||
Attachment #8990336 -
Attachment is obsolete: true
Attachment #9008828 -
Flags: review?(paolo.mozmail)
|
|
Assignee | |
Updated•7 years ago
|
status-firefox63:
affected → ---
|
|
Reporter | |
Comment 10•7 years ago
|
||
Comment on attachment 9008828 [details] [diff] [review]
patch
Thanks!
Attachment #9008828 -
Flags: review?(paolo.mozmail) → review+
|
||
Comment 11•7 years ago
|
||
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/85c0ed4ef9c0
Load checkbox.css and radio.css as document stylesheets. r=paolo
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•