Remove xpinstallConfirm.xul

RESOLVED FIXED in Firefox 64

Status

()

P3
normal
RESOLVED FIXED
9 months ago
6 months ago

People

(Reporter: Paolo, Assigned: kmag)

Tracking

(Blocks: 1 bug)

Trunk
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 wontfix, firefox64 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

9 months ago
This is part of the work tracked in bug 1470830.
Firefox doesn't use xpinstallConfirm.xul anymore. We might want to remove support for this from AddonManager.jsm. Besides, xpinstallConfirm.xul already loads xpinstallConfirm.css as a document stylesheet, so that could just be dropped from xpinstallItem.xml.
Component: Themes → Add-ons Manager
Summary: Load "xpinstallConfirm.css" as a document stylesheet → Remove xpinstallConfirm.xul or load xpinstallConfirm.css as a document stylesheet
Blocks: 1397874
Dropping it from the XUL file sounds reasonable

Comment 3

6 months ago
CC'ing Kris as he might be interested in this.
(Assignee)

Comment 4

6 months ago
This can just go away. Thunderbird and Seamonkey probably still use it, but they can move it to comm-central.

Comment 5

6 months ago
Thanks, I'll add Richard.
(In reply to Jorg K (GMT+2) from comment #5)
> Thanks, I'll add Richard.

Thanks, would one of you be able to take this bug? You probably also want to remove the <resources> as per Comment 1 since it seems like it may work just as well, and we're working towards removing <resources> support anyway.
(Assignee)

Comment 7

6 months ago
I'll do it.
Assignee: nobody → kmaglione+bmo
Comment on attachment 9011969 [details]
Bug 1473933: Remove xpinstallConfirm dialog. r=aswan

Andrew Swan [:aswan] has approved the revision.
Attachment #9011969 - Flags: review+
Comment on attachment 9011996 [details]
Bug 1473933: Part 2 - Remove more unused code. r=aswan

Andrew Swan [:aswan] has approved the revision.
Attachment #9011996 - Flags: review+
Summary: Remove xpinstallConfirm.xul or load xpinstallConfirm.css as a document stylesheet → Remove xpinstallConfirm.xul
Depends on: 1494215

Comment 13

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d9a9e40ab5ce
https://hg.mozilla.org/mozilla-central/rev/21b679ea5cb6
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
status-firefox63: affected → wontfix
You need to log in before you can comment on or make changes to this bug.