1474076 - 404 Not Found when clicking some hyperlinks in about:telemetry

Status: RESOLVED DUPLICATE of bug 1474746

(Toolkit :: Telemetry, defect, P1)

Description

[magicp]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0 ID:20180706224413

Steps to reproduce:
1. Start Nightly (or 61.0)
2. Go to about:telemetry
3. Click on the following hyperlinks

 "Pings"
   (https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/concepts/pings.html)

 "Firefox Telemetry client documentation"
   (https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/telemetry/index.html)

Actual results:
404 Not Found


Expected results:
Shows a linked page

Comment 1

[Jan-Erik Rediger [:janerik]]

Correct links should be: 

https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/docs/telemetry/concepts/pings.html
https://firefox-source-docs.mozilla.org/toolkit/components/telemetry/docs/telemetry/index.html

Comment 2

[Jan-Erik Rediger [:janerik]]

To help Mozilla out with this bug, here's the steps:

0) Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
1) Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
- An artifact build is enough: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Artifact_builds
- If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
- You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
2) Start working on this bug. 
- Open toolkit/content/aboutTelemetry.js
- Look for the links as mentioned in the description.
  - https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/toolkit/content/aboutTelemetry.js#307
  - https://searchfox.org/mozilla-central/rev/28daa2806c89684b3dfa4f0b551db1d099dda7c2/toolkit/content/aboutTelemetry.js#1790
- Change the links to the correct ones as mentioned in comment 1
- If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
3) Build your change with `mach build faster` and open the browser using `mach run`. Go to `about:telemetry` and check that the links are correct now.
4) Submit the patch (including an automated test, if applicable) for review. Mark me as a reviewer so I'll get an email to come look at your code.
- Here's the guide: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
5) After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
6) ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[cgp246]

Hi, I'm new to open source software, and I would like to help with this bug.

Comment 4

[Jan-Erik Rediger [:janerik]]

Hey cgp246, I assigned the bug to you! Looking forward to your contribution. Let me know if anything is unclear or you need further help.

Comment 5

[Jan-Erik Rediger [:janerik]]

Hey cgp246. Bug 1474746 was filed and it looks like we might actually change back to the old structure, making this a non-issue. To avoid doing unnecessary work I suggest you don't work on this just yet (as it might get closed tomorrow or so)

Comment 6

[cgp246]

Ok, thanks for letting me know. I'll look for a different beginner-friendly bug.