1474140 - Stop loading FormAutofillUtils at process startup

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P1)

Description

[Kris Maglione [:kmag]]

It's only needed for a few preference getters most of the time. Those should be split out into a separate JSM.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup.

Review commit: https://reviewboard.mozilla.org/r/255628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255628/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8990568 [details]
Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup.

https://reviewboard.mozilla.org/r/255628/#review262752

Thanks!

::: browser/extensions/formautofill/FormAutofillStorage.jsm:1390
(Diff revision 1)
> +      if (country) {
> -      let localizedName = Services.intl.getRegionDisplayNames(undefined, [country]);
> +        let localizedName = Services.intl.getRegionDisplayNames(undefined, [country]);
> -      hasLocalizedName = localizedName != country;
> +        hasLocalizedName = localizedName != country;
> +      }

Thanks for fixing the warning spew from the change to `getRegionDisplayNames`!

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1f836d71ddc52a92a705feb9dc791413bf63bf6f
Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup. r=MattN

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1f836d71ddc5