Closed Bug 1474140 Opened Last year Closed Last year

Stop loading FormAutofillUtils at process startup

Categories

(Toolkit :: Form Autofill, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

(Blocks 1 open bug)

Details

(Whiteboard: [overhead:80k])

Attachments

(1 file)

It's only needed for a few preference getters most of the time. Those should be split out into a separate JSM.
Comment on attachment 8990568 [details]
Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup.

https://reviewboard.mozilla.org/r/255628/#review262752

Thanks!

::: browser/extensions/formautofill/FormAutofillStorage.jsm:1390
(Diff revision 1)
> +      if (country) {
> -      let localizedName = Services.intl.getRegionDisplayNames(undefined, [country]);
> +        let localizedName = Services.intl.getRegionDisplayNames(undefined, [country]);
> -      hasLocalizedName = localizedName != country;
> +        hasLocalizedName = localizedName != country;
> +      }

Thanks for fixing the warning spew from the change to `getRegionDisplayNames`!
Attachment #8990568 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f836d71ddc52a92a705feb9dc791413bf63bf6f
Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup. r=MattN
https://hg.mozilla.org/mozilla-central/rev/1f836d71ddc5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1478185
You need to log in before you can comment on or make changes to this bug.