Closed Bug 1478185 Opened 6 years ago Closed 6 years ago

Autofill Addresses and Credit cards will not disable

Categories

(Toolkit :: Form Autofill, defect, P1)

Product:
Toolkit
Component:
Form Autofill
Version:
63 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + verified

People

(Reporter: the009, Assigned: MattN)

References

Details

(Keywords: nightly-community, regression)

Attachments

(1 file)

Bug 1478185 - Fix ENABLED_AUTOFILL_*_PREF references after FormAutofillUtils.jsm split. r=sfoster
46 bytes, text/x-phabricator-request
sfoster
: review+
Details | Review 
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
Build ID: 20180724100052

Steps to reproduce:

Going to Options > Security and disabling Autofill addresses Autofill credit and uncheck the boxes.

Restart browser. 


Actual results:

They did not remain unchecked and are enabled on restart.


Expected results:

Disabled options should remain disabled :)
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
20180724223402

(In reply to The009 from comment #0)
> Restart browser. 

No need. You can simply press F5 to refresh about:preferences#privacy

Browser Console output:
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIPrefBranch.setBoolPref] FormAutofillPreferences.jsm:200
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIPrefBranch.setBoolPref] FormAutofillPreferences.jsm:198

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9302fd8c95c05e5a5cd295dde3bbdac2d58d6256&tochange=70f901964f9725e6dfd09750f48996e9d6670492
Blocks: 1474140
Status: UNCONFIRMED → NEW
Has Regression Range: --- → yes
Has STR: --- → yes
Component: Untriaged → Form Autofill
Ever confirmed: true
Flags: needinfo?(kmaglione+bmo)
Keywords: regression
Product: Firefox → Toolkit
Tracking for 63. Kris could you have a look please? Thanks.
tracking-firefox63: ? → +
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Flags: needinfo?(kmaglione+bmo)
Comment on attachment 9001508 [details]
Bug 1478185 - Fix ENABLED_AUTOFILL_*_PREF references after FormAutofillUtils.jsm split. r=sfoster

Sam Foster [:sfoster] has approved the revision.
Attachment #9001508 - Flags: review+
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/07ce0e4ae08d
Fix ENABLED_AUTOFILL_*_PREF references after FormAutofillUtils.jsm split. r=sfoster
https://hg.mozilla.org/mozilla-central/rev/07ce0e4ae08d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: qe-verify+
Hello all ,

I have reproduced the issue mentioned in Description using an affected 63.0a1 build from 2018-07-24.

This issue is verified fixed using the latest Firefox 63.0b8 and Nightly 64.0a1 on Windows 10 64bit.
status-firefox63: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: