Closed Bug 1474254 Opened 6 years ago Closed 6 years ago

GTest is permafailing on Windows ccov builds because it runs out of time

Categories

(Testing :: Code Coverage, defect)

defect
Not set
normal

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: marco, Assigned: calixte)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

GTest is always running over 1200 seconds, which is the max run time for GTest.

I see "TEST-START Jemalloc.JunkPoison" then several "INFO -  Running GTest tests..." followed by several "INFO -  Finished running GTest tests.".
See Also: → 1115253
Do you know what could have changed recently to make this test take this much time?
(In reply to Marco Castelluccio [:marco] from comment #1)
> Do you know what could have changed recently to make this test take this
> much time?

Actually setting needinfo now...
Flags: needinfo?(mh+mozilla)
Attached file log.tar.xz
I assume you mean "code coverage windows builds", because they're pretty much green on all tier-1 windows builds. The test already takes a long time on the tier-1 windows builds. I guess code coverage builds are built with no optimization, and that would likely make them so much slower that they hit the time out. I don't think there's much that can be done here besides disabling the test or increasing the timeout.
Flags: needinfo?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #4)
> I assume you mean "code coverage windows builds", because they're pretty
> much green on all tier-1 windows builds. The test already takes a long time
> on the tier-1 windows builds. I guess code coverage builds are built with no
> optimization, and that would likely make them so much slower that they hit
> the time out. I don't think there's much that can be done here besides
> disabling the test or increasing the timeout.

Yep, I meant coverage builds. They have optimizations enabled, but are slower than normal debug builds anyways.
It's strange though that these tests didn't timeout for months and started consistently timing out only recently.
Would you prefer disabling the test or increasing the timeout?
Summary: GTest is permafailing on Windows builds because it runs out of time → GTest is permafailing on Windows ccov builds because it runs out of time
If disabling is possible without too much hassle, disable.
GTest is permafailing on Windows because of timeout.
Assignee: nobody → cdenizet
Flags: needinfo?(mh+mozilla)
Blocks: 1115253
See Also: 1115253
Comment on attachment 8990940 [details]
Bug 1474254 -- Disable test Jemalloc.JunkPoison for Windows ccov builds.

Mike Hommey [:glandium] has approved the revision.

https://phabricator.services.mozilla.com/D2043
Attachment #8990940 - Flags: review+
Flags: needinfo?(mh+mozilla)
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a52f20385008
Disable test Jemalloc.JunkPoison for Windows ccov builds.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a52f20385008
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
See Also: → 1693790
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: