Closed Bug 1473531 Opened 6 years ago Closed 6 years ago

GTest is permafailing on Mac coverage builds because it runs out of time

Categories

(Testing :: Code Coverage, defect)

Product:
Testing
Component:
Code Coverage
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: marco, Assigned: calixte)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1473531 -- Disable gtest storage_DeadlockDetectorTest.storage_Sanity5DeathTest for macosx ccov build.
46 bytes, text/x-phabricator-request
froydnj
: review+
Details | Review
GTest is always running over 1200 seconds, which is the max run time for GTest.
Assignee: nobody → cdenizet
See Also: → 1474254
On Mac, the failing test is Sanity5DeathTest. On Windows, the failure is different, I see "TEST-START Jemalloc.JunkPoison" then several "INFO - Running GTest tests..." followed by several "INFO - Finished running GTest tests.". Let's make this bug for Mac and I've opened bug 1474254 for Windows.
No longer blocks: 1381163
Summary: GTest is permafailing on Windows and Mac coverage builds because it runs out of time → GTest is permafailing on Mac coverage builds because it runs out of time
:erahm, do you have an idea why this test (Sanity5DeathTest) is taking so much time on mac coverage builds ?
Flags: needinfo?(erahm)
The failing test is storage_DeadlockDetectorTest.storage_Sanity5DeathTest.
For now let's disable this test for macosx ccov builds.
GTest is permafailing because of this test (GTest is always running over 1200s).
(In reply to Calixte Denizet (:calixte) from comment #2) > :erahm, do you have an idea why this test (Sanity5DeathTest) is taking so > much time on mac coverage builds ? My guess is something like bug 1331049, comment 42. I'm fine just disabling for gcov. It would help to have a log to look at.
Flags: needinfo?(erahm)
Comment on attachment 8990742 [details] Bug 1473531 -- Disable gtest storage_DeadlockDetectorTest.storage_Sanity5DeathTest for macosx ccov build. Nathan Froyd [:froydnj] has approved the revision. https://phabricator.services.mozilla.com/D2032
Attachment #8990742 - Flags: review+
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8462a894a7fe Disable gtest storage_DeadlockDetectorTest.storage_Sanity5DeathTest for macosx ccov build.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8462a894a7fe
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: