1474265 - Missing semicolon at DBusRemoteClient.cpp

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1472611#c13

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

Review commit: https://reviewboard.mozilla.org/r/255772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/255772/

Comment 2

[Jan Horak [:jhorak]]

Comment on attachment 8990687 [details]
Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

https://reviewboard.mozilla.org/r/255772/#review262476

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1f6e434d3a8
Add missing semicolon at DBusRemoteClient.cpp, r=jhorak

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/f1f6e434d3a8

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8990687 [details]
Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1472611
[User impact if declined]: Build failure on Wayland
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: Bug 1472611
[Is the change risky?]: no
[Why is the change risky/not risky?]: Wayland only fix, Mozilla does not ship wayland builds
[String changes made/needed]: none

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this marked as not affecting 62 because we only need to uplift it if we uplift the patch from bug 1472611?

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8990687 [details]
Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

Let's take this for beta 8, we want Firefox builds to work well on Linux.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f27de60fff47

Comment 9

[Martin Stránský [:stransky] (ni? me)]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6)
> Is this marked as not affecting 62 because we only need to uplift it if we
> uplift the patch from bug 1472611?

Yes, that's correct. Sorry for the complications.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8990687 [details]
Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on Linux/cairo-gtk3-wayland target.

User impact if declined: Build failure on Linux/cairo-gtk3-wayland target.

Fix Landed on Version: 62

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): The code is used by distros only, Mozilla official builds do not use cairo-gtk3-wayland target. This is also a reason why it passes try.

String or UUID changes made by this patch: none

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8990687 [details]
Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp,

arguably npotb, but in any case, a=me, for 60.3.0.

Comment 13

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/e8abd9a8ce6e