Closed
Bug 1474265
Opened 6 years ago
Closed 6 years ago
Missing semicolon at DBusRemoteClient.cpp
Categories
(Core Graveyard :: X-remote, defect)
Core Graveyard
X-remote
Tracking
(firefox-esr52 unaffected, firefox-esr6063+ fixed, firefox61 unaffected, firefox62 fixed, firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox-esr60 | 63+ | fixed |
firefox61 | --- | unaffected |
firefox62 | --- | fixed |
firefox63 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
Details
(Keywords: regression)
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jhorak
:
review+
lizzard
:
approval-mozilla-beta+
jcristau
:
approval-mozilla-esr60+
|
Details |
Follow up from https://bugzilla.mozilla.org/show_bug.cgi?id=1472611#c13
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8990687 [details] Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp, https://reviewboard.mozilla.org/r/255772/#review262476
Attachment #8990687 -
Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com: https://hg.mozilla.org/integration/autoland/rev/f1f6e434d3a8 Add missing semicolon at DBusRemoteClient.cpp, r=jhorak
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f1f6e434d3a8
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•6 years ago
|
status-firefox61:
--- → unaffected
status-firefox62:
--- → unaffected
status-firefox-esr52:
--- → unaffected
status-firefox-esr60:
--- → unaffected
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8990687 [details] Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp, Approval Request Comment [Feature/Bug causing the regression]: Bug 1472611 [User impact if declined]: Build failure on Wayland [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: Bug 1472611 [Is the change risky?]: no [Why is the change risky/not risky?]: Wayland only fix, Mozilla does not ship wayland builds [String changes made/needed]: none
Attachment #8990687 -
Flags: approval-mozilla-beta?
Comment 6•6 years ago
|
||
Is this marked as not affecting 62 because we only need to uplift it if we uplift the patch from bug 1472611?
Flags: needinfo?(stransky)
Comment 7•6 years ago
|
||
Comment on attachment 8990687 [details] Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp, Let's take this for beta 8, we want Firefox builds to work well on Linux.
Attachment #8990687 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/f27de60fff47
Assignee | ||
Comment 9•6 years ago
|
||
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #6) > Is this marked as not affecting 62 because we only need to uplift it if we > uplift the patch from bug 1472611? Yes, that's correct. Sorry for the complications.
Flags: needinfo?(stransky)
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 8990687 [details] Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp, [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Build failure on Linux/cairo-gtk3-wayland target. User impact if declined: Build failure on Linux/cairo-gtk3-wayland target. Fix Landed on Version: 62 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): The code is used by distros only, Mozilla official builds do not use cairo-gtk3-wayland target. This is also a reason why it passes try. String or UUID changes made by this patch: none
Attachment #8990687 -
Flags: approval-mozilla-esr60?
Comment 12•6 years ago
|
||
Comment on attachment 8990687 [details] Bug 1474265 - Add missing semicolon at DBusRemoteClient.cpp, arguably npotb, but in any case, a=me, for 60.3.0.
Attachment #8990687 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 13•6 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/e8abd9a8ce6e
Updated•6 years ago
|
tracking-firefox-esr60:
--- → 63+
Updated•5 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•