Closed Bug 1474413 Opened Last year Closed 9 months ago

Update add-on studies in place when the recipe changes.


(Firefox :: Normandy Client, enhancement, P1)




Firefox 67
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- wontfix
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed


(Reporter: mythmon, Assigned: rehan)




(1 file, 1 obsolete file)

When the add-on listed in an add-on (aka opt-out) study does not match the currently installed add-on for the study, the old add-on should be removed and replaced with the new add-on.

Updating add-ons in place could cause strange effects in relation to the shield studies. We'll have to take care to not make existing studies think that the study is ending.
If my understanding on this matter is correct, we want this change in order not to lose and reuse the user study bucket when the study add-on needs adjustments or to be completely changed. 
I'm not sure at this point what changes are required on Normandy client side and risks involved plus I assume we'll want the changes uplifted as well? I would suggest an additional telemetry status for this change.

Setting flags accordingly; Mike can you please update the tracking flags in order to reflect what versions we will target with this change?
Flags: qe-verify+
Flags: needinfo?(mcooper)
This change won't be small, and I plan to do it as a part of a migration to a local action. Because of this, I'm not planning to request uplift for the feature.
Depends on: 1440780
Priority: -- → P2
Assignee: nobody → rdalal
Priority: P2 → P1
Depends on: 1528458
Attachment #9044849 - Attachment is obsolete: true
Keywords: checkin-needed

Failed to land:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpVd165v\npatching file toolkit/components/normandy/test/browser/head.js\nHunk #1 succeeded at 11 with fuzz 2 (offset 2 lines).\npatching file toolkit/components/normandy/test/browser/browser_actions_AddonStudyAction.js\nHunk #4 FAILED at 166\nHunk #12 FAILED at 882\n2 out of 12 hunks FAILED -- saving rejects to file toolkit/components/normandy/test/browser/browser_actions_AddonStudyAction.js.rej\npatching file toolkit/components/normandy/lib/TelemetryEvents.jsm\nHunk #1 FAILED at 26\n1 out of 1 hunks FAILED -- saving rejects to file toolkit/components/normandy/lib/TelemetryEvents.jsm.rej\nabort: patch failed to apply', '')

Please take a look.

Flags: needinfo?(rdalal)
Attachment #9043067 - Attachment description: Bug 1474413 - Update addon studies in place r?mythmon → Bug 1474413 - Update addon studies in place r=mythmon
Keywords: checkin-needed

Pushed by
Update addon studies in place r=mythmon,glasserc

Keywords: checkin-needed
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Whiteboard: [qa-triaged]
QA Whiteboard: [qa-triaged]
Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.