1474413 - Update add-on studies in place when the recipe changes.

Status: RESOLVED FIXED

(Firefox :: Normandy Client, enhancement, P1)

Description

[Michael Cooper [:mythmon]]

When the add-on listed in an add-on (aka opt-out) study does not match the currently installed add-on for the study, the old add-on should be removed and replaced with the new add-on.

Updating add-ons in place could cause strange effects in relation to the shield studies. We'll have to take care to not make existing studies think that the study is ending.

Comment 1

[Adrian Florinescu [:adrian_sv]]

If my understanding on this matter is correct, we want this change in order not to lose and reuse the user study bucket when the study add-on needs adjustments or to be completely changed. 
I'm not sure at this point what changes are required on Normandy client side and risks involved plus I assume we'll want the changes uplifted as well? I would suggest an additional telemetry status for this change.

Setting flags accordingly; Mike can you please update the tracking flags in order to reflect what versions we will target with this change?

Comment 2

[Michael Cooper [:mythmon]]

This change won't be small, and I plan to do it as a part of a migration to a local action. Because of this, I'm not planning to request uplift for the feature.

Comment 3

[Rehan Dalal [:rehan, :rdalal]]

Attachment: Bug 1474413 - Update addon studies in place r=mythmon

Comment 4

[Rehan Dalal [:rehan, :rdalal]]

Attachment: Bug 1474413 - Update addon studies in place r?mythmon

Comment 5

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be8163beec12b17b15c696e5210c1fee032ec66e

Comment 6

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa31649538fc6df08f0b724da52ee9c698f51b32

Comment 7

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dbcb957185e8646914ed22eca3a712bf0f7255b

Comment 8

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6ddde480f6974c14f55d6e9a21391367de2306a

Comment 9

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=50c8e2381c04889029ed5330a876796868e7c9ad

Comment 10

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1062cb7f0b40dbe77323885026b70efa1f0a3a16

Comment 11

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15562741c2110fcda80ee86dd26eac7d52016bc5

Comment 12

[Rehan Dalal [:rehan, :rdalal]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1f6477fe27b0d7077fd2ce94f185d694ee40909

Comment 13

[Cristina Coroiu [:ccoroiu]]

Failed to land:
Details: We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. (255, 'applying /tmp/tmpVd165v\npatching file toolkit/components/normandy/test/browser/head.js\nHunk #1 succeeded at 11 with fuzz 2 (offset 2 lines).\npatching file toolkit/components/normandy/test/browser/browser_actions_AddonStudyAction.js\nHunk #4 FAILED at 166\nHunk #12 FAILED at 882\n2 out of 12 hunks FAILED -- saving rejects to file toolkit/components/normandy/test/browser/browser_actions_AddonStudyAction.js.rej\npatching file toolkit/components/normandy/lib/TelemetryEvents.jsm\nHunk #1 FAILED at 26\n1 out of 1 hunks FAILED -- saving rejects to file toolkit/components/normandy/lib/TelemetryEvents.jsm.rej\nabort: patch failed to apply', '')

Please take a look.

Comment 14

[Rehan Dalal [:rehan, :rdalal]]

Rebased and tested:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a3e21a9fee5a59d0713211a1d49581d69e66ef6

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a920a704ff6b
Update addon studies in place r=mythmon,glasserc

Comment 16

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a920a704ff6b