1474638 - Remove nsIDownloadHistory::removeAllDownloads

Status: RESOLVED FIXED

(Toolkit :: Places, enhancement, P1)

Description

[Mark Banner (:standard8)]

We no longer need nsIDownloadHistory::removeAllDownloads, we can replace it with PlacesUtils.history.removeVisitsByFilter if we add an additional filter type to filter by transition.

Part of the work towards bug 1468980 - removing nsIDownloadHistory completely.

Comment 1

[Mark Banner (:standard8)]

I started removing removeAllDownloads from the c++ code, and then discovered I could remove a lot more. Including some parts of the batching system, hence adding blocking for bug 897954 as well.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1474638 - Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter.

Also change PlacesUtils.history.removeVisitsByFilter to be able to remove by transition type.

MozReview-Commit-ID: Bkiv0ScUi07

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1474638 - Remove nsIDownloadHistory::removeAllDownloads.

Depends on D2056

Comment 4

[Mark Banner (:standard8)]

Try push is here:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dae1154e66c7f23ec6d10585db96e4f527bc4fc

Comment 5

[Phabricator Automation]

Comment on attachment 8991106 [details]
Bug 1474638 - Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2056

Comment 6

[Phabricator Automation]

Comment on attachment 8991107 [details]
Bug 1474638 - Remove nsIDownloadHistory::removeAllDownloads.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2057

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43dc237c33f3
Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter. r=mak

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e729ca38f8c
Remove nsIDownloadHistory::removeAllDownloads. r=mak

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/43dc237c33f3
https://hg.mozilla.org/mozilla-central/rev/4e729ca38f8c