Closed Bug 1474638 Opened 6 years ago Closed 6 years ago

Remove nsIDownloadHistory::removeAllDownloads

Categories

(Toolkit :: Places, enhancement, P1)

Product:
Toolkit
Component:
Places
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

Bug 1474638 - Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter.
46 bytes, text/x-phabricator-request
mak
: review+
Details | Review
Bug 1474638 - Remove nsIDownloadHistory::removeAllDownloads.
46 bytes, text/x-phabricator-request
mak
: review+
Details | Review 
We no longer need nsIDownloadHistory::removeAllDownloads, we can replace it with PlacesUtils.history.removeVisitsByFilter if we add an additional filter type to filter by transition.

Part of the work towards bug 1468980 - removing nsIDownloadHistory completely.
I started removing removeAllDownloads from the c++ code, and then discovered I could remove a lot more. Including some parts of the batching system, hence adding blocking for bug 897954 as well.
Blocks: 897954
Also change PlacesUtils.history.removeVisitsByFilter to be able to remove by transition type.

MozReview-Commit-ID: Bkiv0ScUi07
Comment on attachment 8991106 [details]
Bug 1474638 - Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2056
Attachment #8991106 - Flags: review+
Comment on attachment 8991107 [details]
Bug 1474638 - Remove nsIDownloadHistory::removeAllDownloads.

Marco Bonardo [::mak] has approved the revision.

https://phabricator.services.mozilla.com/D2057
Attachment #8991107 - Flags: review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/43dc237c33f3
Change users of nsIDownloadHistory::removeAllDownloads() to PlacesUtils.history.removeVisitsByFilter. r=mak
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e729ca38f8c
Remove nsIDownloadHistory::removeAllDownloads. r=mak
https://hg.mozilla.org/mozilla-central/rev/43dc237c33f3
https://hg.mozilla.org/mozilla-central/rev/4e729ca38f8c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.