Closed
Bug 897954
Opened 11 years ago
Closed 3 years ago
Remove onBegin/OnEndUpdateBatch
Categories
(Toolkit :: Places, defect, P3)
Toolkit
Places
Tracking
()
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: mak, Assigned: daisuke)
References
Details
Attachments
(3 files)
with bug 894331, the main reason to have these notifications goes away. While they may be useful to figure if there's heavy work ongoing, it's a very few consumers doing that, and those are mostly working asynchronously nowadays. I quickly audit mxr and couldn't find very compelling use-cases for them. Adding this to the fact async batches may be a nightmare, I suspect we will just slowly move towards total removal of the batching concept.
Reporter | ||
Updated•7 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•3 years ago
|
||
The only remaining thing is that PlacesDBUtils must notify all the results to do a refresh, because otherwise the UI views and memory results would be outdated after maintenance. We could introduce a purge-caches event for when direct writes to the db happen and the caches and views should be rebuilt.
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 87.2 - Feb 8 - Feb 21
Points: --- → 3
Assignee | ||
Comment 2•3 years ago
|
||
Assignee | ||
Comment 3•3 years ago
|
||
Depends on D105440
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D105441
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e558ac8e419 Implement and apply purge-caches mechanism. r=mak https://hg.mozilla.org/integration/autoland/rev/9443814d173b Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak https://hg.mozilla.org/integration/autoland/rev/0a60eb3f7ba8 Add a test for purging caches. r=mak
Comment 6•3 years ago
|
||
Backed out for causing node test failures in PlacesFeed.
Backout link: https://hg.mozilla.org/integration/autoland/rev/3703efb779d013c97c60486eb369229c93c2589f
Flags: needinfo?(daisuke)
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1be6f831ea50 Implement and apply purge-caches mechanism. r=mak https://hg.mozilla.org/integration/autoland/rev/3916fec5125b Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak https://hg.mozilla.org/integration/autoland/rev/9fb7a7ee8ab4 Add a test for purging caches. r=mak
Comment 8•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1be6f831ea50
https://hg.mozilla.org/mozilla-central/rev/3916fec5125b
https://hg.mozilla.org/mozilla-central/rev/9fb7a7ee8ab4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•