Closed Bug 897954 Opened 11 years ago Closed 3 years ago

Remove onBegin/OnEndUpdateBatch

Categories

(Toolkit :: Places, defect, P3)

defect
Points:
3

Tracking

()

RESOLVED FIXED
88 Branch
Iteration:
87.2 - Feb 8 - Feb 21
Tracking Status
firefox88 --- fixed

People

(Reporter: mak, Assigned: daisuke)

References

Details

Attachments

(3 files)

with bug 894331, the main reason to have these notifications goes away. While they may be useful to figure if there's heavy work ongoing, it's a very few consumers doing that, and those are mostly working asynchronously nowadays.
I quickly audit mxr and couldn't find very compelling use-cases for them.

Adding this to the fact async batches may be a nightmare, I suspect we will just slowly move towards total removal of the batching concept.
Depends on: 1340498
Priority: -- → P3
Depends on: 1473530
No longer depends on: 1340498
Depends on: 1474638

The only remaining thing is that PlacesDBUtils must notify all the results to do a refresh, because otherwise the UI views and memory results would be outdated after maintenance. We could introduce a purge-caches event for when direct writes to the db happen and the caches and views should be rebuilt.

Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Iteration: --- → 87.2 - Feb 8 - Feb 21
Points: --- → 3

Depends on D105441

Blocks: 1694818
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e558ac8e419
Implement and apply purge-caches mechanism. r=mak
https://hg.mozilla.org/integration/autoland/rev/9443814d173b
Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
https://hg.mozilla.org/integration/autoland/rev/0a60eb3f7ba8
Add a test for purging caches. r=mak
Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1be6f831ea50
Implement and apply purge-caches mechanism. r=mak
https://hg.mozilla.org/integration/autoland/rev/3916fec5125b
Remove onBeginUpdateBatch and onEndUpdateBatch functions. r=mak
https://hg.mozilla.org/integration/autoland/rev/9fb7a7ee8ab4
Add a test for purging caches. r=mak
You need to log in before you can comment on or make changes to this bug.