Enable the multiselect tabs feature by default on Nightly builds

VERIFIED FIXED in Firefox 63

Status

()

enhancement
P3
normal
VERIFIED FIXED
11 months ago
6 months ago

People

(Reporter: jaws, Assigned: ablayelyfondou)

Tracking

(Blocks 1 bug, {feature})

Trunk
Firefox 63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed, firefox64 verified, firefox65 verified)

Details

Attachments

(1 attachment)

Once bug 1472910 is fixed, then we can enable the multiselect tabs feature by default on Nightly builds.

I'd like to wait until bug 1472910 is fixed since it changes behavior of "Close other tabs" and could cause dataloss if people don't expect tabs from their selection to get closed.

To enable this only for Nightly builds, firefox.js should be updated to enable the pref when NIGHTLY_BUILD is defined, otherwise leaving it disabled.

See https://searchfox.org/mozilla-central/rev/c579ce13ca7864c5df9711eda730ceb00501aed3/browser/app/profile/firefox.js#1313,1315,1317 for an example.
Jared, could you also file a bug for letting the preference ride the 63 train? I'd like to track the pref change for the release.

Also, once this is activated in nightly, could you nominate it for release notes addition (https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F) to the bug so as that we add it to Fx63 Nightly release notes. Thanks!
Flags: needinfo?(jaws)
I filed bug 1474938 to let the pref ride the trains.

I'll nominate it for release notes addition when this bug is fixed.
Flags: needinfo?(jaws)
Assignee

Updated

10 months ago
Assignee: nobody → ablayelyfondou
Comment hidden (mozreview-request)
Comment on attachment 8992242 [details]
Bug 1474704 - Enable the multiselect tabs feature by default on Nightly builds.

https://reviewboard.mozilla.org/r/257136/#review263992
Attachment #8992242 - Flags: review?(jaws) → review+

Comment 5

10 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/057ccf1cc3fc
Enable the multiselect tabs feature by default on Nightly builds. r=jaws
Backed out changeset 057ccf1cc3fc (bug 1474704) for bc failures on browser_multiselect_tabs_using_Ctrl.js

Backout: https://hg.mozilla.org/integration/autoland/rev/5e1cb45e2ded70dd28882ab6c83735b6bc030965

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=057ccf1cc3fc667350619a2bc4e6d656c9050432&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=188334813 

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188334813&repo=autoland&lineNumber=1527

04:53:54     INFO - TEST-START | browser/base/content/test/tabs/browser_multiselect_tabs_using_Ctrl.js
04:54:01     INFO - TEST-INFO | started process screencapture
04:54:01     INFO - TEST-INFO | screencapture: exit 0
04:54:01     INFO - Buffered messages logged at 04:53:54
04:54:01     INFO - Entering test bound clickWithoutPrefSet
04:54:01     INFO - TEST-PASS | browser/base/content/test/tabs/browser_multiselect_tabs_using_Ctrl.js | Tab doesn't have focus - 
04:54:01     INFO - Buffered messages finished
04:54:01     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_using_Ctrl.js | Uncaught exception - Wait for the selectedTab getter to update - timed out after 50 tries.
Flags: needinfo?(ablayelyfondou)
browser_multiselect_tabs_using_Ctrl.js and I think a few other tests make an assumption that the pref is false by default, which will now change. So in these tests you will have to explicitly set the pref to false, and then add a registerCleanupFunction that will call clearUserPref.
Comment hidden (obsolete)
Comment hidden (mozreview-request)
Assignee

Comment 10

10 months ago
(In reply to Mike Conley (:mconley) (:⚙️) (PTO Jul 24th-Aug 6th)) from comment #8)
> Alternatively, use SpecialPowers.pushPrefEnv, so you get the end-of-test
> clean-up for free.

Thank you Mike, we have been using that in fact.
Flags: needinfo?(ablayelyfondou)
Whoops! I should have noticed that by actually looking at the patch. My apologies. I'll mark my comment as obsolete.
Assignee

Comment 12

10 months ago
You don't need to apologize I think :).
(In reply to Mike Conley (:mconley) (:⚙️) (PTO Jul 24th-Aug 6th)) from comment #8)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> > So in
> > these tests you will have to explicitly set the pref to false, and then add
> > a registerCleanupFunction that will call clearUserPref.
> 
> Alternatively, use SpecialPowers.pushPrefEnv, so you get the end-of-test
> clean-up for free.

Yes, you are right and that's what I should have said :)

Comment 14

10 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b015aca4441
Enable the multiselect tabs feature by default on Nightly builds. r=jaws

Comment 15

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3b015aca4441
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63

Updated

10 months ago
Keywords: feature
This bug was about "Enabling the multiselect tabs feature by default on Nightly builds" and I have seen the feature being implemented with latest Nightly!

Build ID 	20180730221422
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0
QA Whiteboard: [bugday-20180801]
Verified fixed in latest nightly 65.0a1(2018-11-08) on Windows 10x64, macOS 10.13 and Ubuntu 16.04x64. Feature is implemented with latest Nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.