1474862 - TEST-UNEXPECTED-FAIL tests/mozmill/pref-window/test-font-chooser.js

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: test-font-chooser

This test is permanently orange, and I'm sick of looking at it. The test is opening a dialog, which isn't consistent with what the preferences UI does. So I've stopped it doing that and it seems to be green again.

Comment 1

[Jorg K (CEST = GMT+2)]

Comment on attachment 8991270 [details] [diff] [review]
test-font-chooser

Where do you see this orange? Not on "my" tree ;-) - What am I missing?

Didn't Aecman fix this in bug 1460721?

Comment 2

[:aceman]

Comment on attachment 8991270 [details] [diff] [review]
test-font-chooser

Review of attachment 8991270 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for noticing this. It is always preferred to click the native buttons in the same way what the user could do. I don't know why the openDialog was hardcoded there, bypassing the proper button for that.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7ddfa5f4cc13
improve test-font-chooser.js so it clicks instead of using openDialog(). r=aceman

Comment 4

[Jorg K (CEST = GMT+2)]

Please provide a decent commit message next time.

Comment 5

[Jorg K (CEST = GMT+2)]

Geoff, this test only appears to be orange in the context of your Calendar/overlay work, see for example here:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=833519c1ee7c38435b0827a584645eaf9be8f6c4&selectedJob=188345434

Otherwise we don't see this failure, and we also didn't see it even before you improved the test in this bug here. So right now I'm not landing the Calendar/overlay work since it appears that it triggers this failure.

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8991270 [details] [diff] [review]
test-font-chooser

Let's get this into TB 62 together with the Calendar stuff that motivated the changes here.

Comment 7

[Jorg K (CEST = GMT+2)]

Beta (TB 62):
https://hg.mozilla.org/releases/comm-beta/rev/77deaa6efae02839355093e8eef28e755479a572