Closed Bug 1474925 Opened 3 years ago Closed 3 years ago
Picker swipe not possible in landscape
59 bytes, text/x-review-board-request
The TimePicker cannot be swiped when in landscape because by being placed in a ScrollView  and overflowing it, the ScrollView catches the swipe motion. Issue easily seen here - https://drive.google.com/file/d/1bqXUnig_JWuSmnmCgOYUl_3pZpDwZYfJ/view?usp=sharing  https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/mobile/android/base/java/org/mozilla/gecko/prompts/Prompt.java#412
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Comment on attachment 8992277 [details] Bug 1474925 - TimePicker swipe not possible in landscape; https://reviewboard.mozilla.org/r/257160/#review264174
Attachment #8992277 - Flags: review?(nchen) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/5bac5fa077ea TimePicker swipe not possible in landscape; r=jchen
Backed out for failing android-lint Push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5bac5fa077ea9b729951ccf18cbe6c0dccdc11a1 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188617477&repo=autoland&lineNumber=893 Backout: https://hg.mozilla.org/integration/autoland/rev/fd58bf35fd2db310e1f710fdf9785a6f23453fd2
Fixed the lint issue.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f3c4739ba1ba TimePicker swipe not possible in landscape; r=jchen
Petru-Mugurel, everything here looks like it has been checked in. Does the "checkin-needed" belong to a different bug?
Flags: needinfo?(petru.lingurar) → qe-verify+
Checked this fix in the latest Nightly and everything works as expected. Marking as Verified.
Comment on attachment 8992277 [details] Bug 1474925 - TimePicker swipe not possible in landscape; Approval Request Comment [Feature/Bug causing the regression]: TimePicker swipe not possible in landscape [User impact if declined]: The normal way of swiping to select a certain time in the Material TimePicker is not possible on some devices while on landscape. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: -- [List of other uplifts needed for the feature/fix]: -- [Is the change risky?]: No [Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported. [String changes made/needed]: --
Attachment #8992277 - Flags: approval-mozilla-beta?
Comment on attachment 8992277 [details] Bug 1474925 - TimePicker swipe not possible in landscape; One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. Let's uplift for next Monday's beta 17 build.
Attachment #8992277 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Can you please check this, Igor?
Devices: - HTC Desire 820 (Android 6.0.1); - Samsung Galaxy Note 8 (Android 8.0.0). Verified as fixed in 62.0b17.
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.