1474925 - TimePicker swipe not possible in landscape

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

The TimePicker cannot be swiped when in landscape because by being placed in a ScrollView [1] and overflowing it, the ScrollView catches the swipe motion.

Issue easily seen here - https://drive.google.com/file/d/1bqXUnig_JWuSmnmCgOYUl_3pZpDwZYfJ/view?usp=sharing

[1] https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/mobile/android/base/java/org/mozilla/gecko/prompts/Prompt.java#412

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1474925 - TimePicker swipe not possible in landscape;

Review commit: https://reviewboard.mozilla.org/r/257160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257160/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992277 [details]
Bug 1474925 - TimePicker swipe not possible in landscape;

https://reviewboard.mozilla.org/r/257160/#review264174

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bac5fa077ea
TimePicker swipe not possible in landscape; r=jchen

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing android-lint 

Push that caused the failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5bac5fa077ea9b729951ccf18cbe6c0dccdc11a1

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=188617477&repo=autoland&lineNumber=893

Backout: https://hg.mozilla.org/integration/autoland/rev/fd58bf35fd2db310e1f710fdf9785a6f23453fd2

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8992277 [details]
Bug 1474925 - TimePicker swipe not possible in landscape;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257160/diff/1-2/

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Fixed the lint issue.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3c4739ba1ba
TimePicker swipe not possible in landscape; r=jchen

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f3c4739ba1ba

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Petru-Mugurel, everything here looks like it has been checked in. Does the "checkin-needed" belong to a different bug?

Comment 10

[Petru-Mugurel Lingurar [:petru]]

Indeed, sorry!

Comment 11

[Bogdan Surd, QA [:bsurd, NI]]

Checked this fix in the latest Nightly and everything works as expected.

Marking as Verified.

Comment 12

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8992277 [details]
Bug 1474925 - TimePicker swipe not possible in landscape;

Approval Request Comment
[Feature/Bug causing the regression]: TimePicker swipe not possible in landscape
[User impact if declined]: The normal way of swiping to select a certain time in the Material TimePicker is not possible on some devices while on landscape.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:  --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Has been QE verified and in the time being in Nightly no issues have been reported.
[String changes made/needed]: --

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992277 [details]
Bug 1474925 - TimePicker swipe not possible in landscape;

One of several small fixes for the date picker related to the switch in 62 to using the platform library. Verified in nightly. 
Let's uplift for next Monday's beta 17 build.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f3146c971a5f

Comment 15

[Ioana Chiorean]

Can you please check this, Igor?

Comment 16

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - HTC Desire 820 (Android 6.0.1);
 - Samsung Galaxy Note 8 (Android 8.0.0).

Verified as fixed in 62.0b17.