1474934 - Add support for POST in WebExtensions search

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

See also bug 336208

We need to expand the capabilities of addEngineWithDetails to allow for POST engines so we can add that to the WebExtensions API.

We need to add POST support in particular.

Comment 1

[Mike Kaply [:mkaply]]

It's in search, I just didn't add it to WebExtensions for some reason.

Comment 2

[Mike Kaply [:mkaply]]

Looks like chrome doesn't support it properly either :)

https://bugs.chromium.org/p/chromium/issues/detail?id=268698

Comment 3

[Mike Kaply [:mkaply]]

Attachment: Preliminary patch

Florian:

So while addEngineWithDetails supported changing the method to POST, it had no way to pass the post params as a separate thing.

Do you think the intention was that you would include the postParams as part of the URL:

http://foo.com?bar={searchTerms}

And the parameters would get turned into postData?

I don't see any code where that would happen.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8991750 [details] [diff] [review]
Preliminary patch

Since bug 1477076 is fixed, I think the questions from comment 3 are all answered already.

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bug 1474934 - Add support for POST search to WebExtensions

Comment 6

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 9003240 [details]
Bug 1474934 - Add support for POST search to WebExtensions

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f70b8597ad1d
Add support for POST search to WebExtensions r=mixedpuppy

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f70b8597ad1d

Comment 9

[Vlad Jiman]

Will manual testing be required on this bug? If yes, please provide some info onto how to correctly validate the changes, otherwise set the 'qe-verify-' flag. Thanks!

Comment 10

[Mike Kaply [:mkaply]]

Attachment: manifest.json

Attached is a manifest.json that uses POST for DuckDuckGo.

This should be enough to verify. You can test on old Firefox to see it doesn't work and on current Firefox.

What's interesting about POST engines is that you don't see the search term in the URL bar.

Comment 11

[Vlad Jiman]

Thank you for the manifest and info, I've verified using Firefox versions 62.0.2, 63.0b9 that the extension containing the above manifest does not work and while using the latest Nightly 64.0a1 it did work. Tests were performed on Windows 10 x64.