1475023 - Icon fallback in contentSearchUI doesn't look like it actually works (anymore?)

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect, P5)

Description

[:Gijs (out until Jan 5th; he/him)]

STR:

1. run ./mach mochitest browser/base/content/test/urlbar/browser_action_searchengine.js

ER:

no security errors in the output

AR:

Security Error: Content at about:newtab may not load or link to chrome://mozapps/skin/places/defaultFavicon.svg



I haven't actually debugged this, but from the DXR results, this looks like this code: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/contentSearchUI.js#88 .

I don't know to what degree this matters in the sense that I expect few if any search providers wouldn't provide an icon - but in any case, if they do not, the fallback won't work.

Workarounds include having a different fallback icon, no fallback icon, one from a data URI, or perhaps using a chrome override to make the current default icon available in a location that's marked contentaccessible (assuming the current one isn't).

Comment 1

[Drew Willcoxon :adw]

I guess making about:newtab unprivileged/remote broke this.

Comment 2

[Mark Banner (:standard8)]

Bug 1673758 has just changed the default icon, but I couldn't reproduce the errors in this test from before that build (though I did see some similar errors when writing the patch...). In any case, I think we can mark this as WFM.