Closed Bug 1475141 Opened Last year Closed Last year

Improve "lastTestSeen" string in reftests

Categories

(Testing :: Reftest, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: kmag, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1472280 +++

We're also seeing bug 1471222 in a bunch of reftests, where the failure output still confusingly suggests that the timeout happened on whatever test ran last, even though the last test finished.
Andrew, any chance you can do something similar here to what you did in bug 1472280?

The reftest ASan shutdown hangs in bug 1471222 have gotten pretty bad, and I'd like to update bug 1475141's patches to deal with them.
Flags: needinfo?(ahal)
Yeah, I'll try to find some time for this in the next week or two.
Assignee: nobody → ahal
Status: NEW → ASSIGNED
Sorry for the delay on this. I have a patch up on try now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d99b9ec5b4fbf34e7560627ccf7a92630441c39
Flags: needinfo?(ahal)
This will also change lastTestSeen to "Last test finished" after the 'last'
test in the run has completed. This will prevent us from misattributing
shutdown (and between-test failures) to the unlucky test that happened to run
beforehand.
Comment on attachment 9005611 [details]
Bug 1475141 - [reftest] Make sure self.lastTestSeen displays whether the test was in-progress or finished, r=jmaher

Joel Maher ( :jmaher PTO - back Sep 4 ) (UTC-4) has approved the revision.
Attachment #9005611 - Flags: review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/270e36de2a74
[reftest] Make sure self.lastTestSeen displays whether the test was in-progress or finished, r=jmaher
https://hg.mozilla.org/mozilla-central/rev/270e36de2a74
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.