1475141 - Improve "lastTestSeen" string in reftests

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Kris Maglione [:kmag]]

+++ This bug was initially created as a clone of Bug #1472280 +++

We're also seeing bug 1471222 in a bunch of reftests, where the failure output still confusingly suggests that the timeout happened on whatever test ran last, even though the last test finished.

Comment 1

[Kris Maglione [:kmag]]

Andrew, any chance you can do something similar here to what you did in bug 1472280?

The reftest ASan shutdown hangs in bug 1471222 have gotten pretty bad, and I'd like to update bug 1475141's patches to deal with them.

Comment 2

[Andrew Halberstadt [:ahal]]

Yeah, I'll try to find some time for this in the next week or two.

Comment 3

[Andrew Halberstadt [:ahal]]

Sorry for the delay on this. I have a patch up on try now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d99b9ec5b4fbf34e7560627ccf7a92630441c39

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1475141 - [reftest] Make sure self.lastTestSeen displays whether the test was in-progress or finished, r=jmaher

This will also change lastTestSeen to "Last test finished" after the 'last'
test in the run has completed. This will prevent us from misattributing
shutdown (and between-test failures) to the unlucky test that happened to run
beforehand.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9005611 [details]
Bug 1475141 - [reftest] Make sure self.lastTestSeen displays whether the test was in-progress or finished, r=jmaher

Joel Maher ( :jmaher PTO - back Sep 4 ) (UTC-4) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/270e36de2a74
[reftest] Make sure self.lastTestSeen displays whether the test was in-progress or finished, r=jmaher

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/270e36de2a74