Closed
Bug 1475209
Opened 7 years ago
Closed 7 years ago
Get rid of EnumDevResolver in MediaDevices.cpp by using a promise/mozpromise/pledge solution directly.
Categories
(Core :: WebRTC: Audio/Video, enhancement, P3)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: achronop, Assigned: jib)
References
Details
Attachments
(1 file)
This is coming from the review of Bug 1152401. The way that EnumDevResolver converts to nsIVariant and back is redundant. A better way would be to replace MediaManager::EnumerateDevices to return a Pledge and handle success or reject events in the same place. MozPromise is not appropriate, as MediaManager::EnumerateDevices includes IPC.
|
Reporter | |
Updated•7 years ago
|
|
||
Comment 1•7 years ago
|
||
Please don't use Pledge anymore...
Should be using MozPromise.
|
|
||
Comment 2•7 years ago
|
||
And if it can't be used over IPC, then add IPC supports :)
|
Assignee | |
Updated•7 years ago
|
Summary: Change MediaManager::EnumerateDevices to return a Pledge. → Get rid of EnumDevResolver in MediaDevices.cpp by using a promise/mozpromise/pledge solution directly.
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → jib
|
||
Updated•7 years ago
|
Attachment #9015285 -
Attachment description: Bug 1475209 - Have MediaManager::EnumerateDevices() return a promise. r?achronop → Bug 1475209 - Have MediaManager::EnumerateDevices() return a promise. r?achronop!,jya!
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a616c269bbcc
Have MediaManager::EnumerateDevices() return a promise. r=achronop,jya
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•