1479841 - Start replacing uses of Pledge with MozPromise in MediaManager (cleanup)

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

As mentioned in bug 934425 comment 44:
> So... the reason EnumerateDevicesImpl() still returns a Pledge, and hasn't yet been converted to
> MozPromise, is that EnumerateDevicesImpl() does quite a lot of work in the master process and
> waits for an IPC response. Pledge was written to allow clean tear-down of the content process
> even with outstanding IPC responses, and neither resolve nor reject in that case, by design.

It should still be doable to convert this to use MozPromise, if we stash outstanding MozPromise requests and call Disconnect() on them in OnNavigation. 

We should write and land a test first, to make sure we don't accidentally alter this behavior. Filed as bug 1479840.

We might also want to take advantage of MozPromise IPDL support bug 1313200 at the same time.

Comment 2

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d1b44942f12773b5ea0a9669dc06243f0c179f9

Comment 3

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a15f91a0b4a21292431ed43532e6d3ccffc89d9a

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Use promise base ipdl api and remove unnecessary IPC response. r?jib

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Apply ipdl changes to MediaChild and use the promise to return the key. r?jib

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Apply ipdl changes to MediaParent and pass back the key through the resolver. r?jib

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Use promises instead of pledges through out audio device enumeration code path. r?jib

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9010197 [details]
Bug 1479841 - Use promise base ipdl api and remove unnecessary IPC response. r?jib

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.

Comment 9

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ac5c74b24294b7073291743e575a808c0973137a

Comment 10

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d69d70308c39dc785756c48471d1bae65d2ade77

Comment 11

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Use promise base ipdl api and remove unnecessary IPC response. r?jib

Comment 12

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Apply ipdl changes to MediaChild and use the promise to return the key. r?jib

Comment 13

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Apply ipdl changes to MediaParent and pass back the key through the resolver. r?jib

Comment 14

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1479841 - Use promises instead of pledges through out audio device enumeration code path. r?jib

Comment 15

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9010198 [details]
Bug 1479841 - Apply ipdl changes to MediaChild and use the promise to return the key. r?jib

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.

Comment 16

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9010199 [details]
Bug 1479841 - Apply ipdl changes to MediaParent and pass back the key through the resolver. r?jib

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.

Comment 17

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b276809f822f9f9e9611fb85582285a624305577

Comment 18

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9010200 [details]
Bug 1479841 - Use promises instead of pledges through out audio device enumeration code path. r?jib

Jan-Ivar Bruaroey [:jib] (needinfo? me) has approved the revision.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79eec88b1315
Use promise base ipdl api and remove unnecessary IPC response. r=jib
https://hg.mozilla.org/integration/autoland/rev/5ad68af3960a
Apply ipdl changes to MediaChild and use the promise to return the key. r=jib
https://hg.mozilla.org/integration/autoland/rev/eb7d4eac27b5
Apply ipdl changes to MediaParent and pass back the key through the resolver. r=jib
https://hg.mozilla.org/integration/autoland/rev/69b1d1c5e010
Use promises instead of pledges through out audio device enumeration code path. r=jib

Comment 20

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/79eec88b1315
https://hg.mozilla.org/mozilla-central/rev/5ad68af3960a
https://hg.mozilla.org/mozilla-central/rev/eb7d4eac27b5
https://hg.mozilla.org/mozilla-central/rev/69b1d1c5e010