Closed Bug 1475224 Opened 3 years ago Closed 3 years ago

Various fixes to make the Provider ready for Lightning 6.2 / Thunderbird 60

Categories

(Calendar :: Provider: GData, enhancement)

Lightning 6.2
enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Fallen, Assigned: Fallen)

References

Details

Attachments

(6 files, 2 obsolete files)

There are a few issues that need to be fixed for the new provider release. They are all fairly small issues, so I am gathering them here.
Attached patch Increase browserRequest size - v1 (obsolete) β€” β€” Splinter Review
Attachment #8991604 - Flags: review?(makemyday)
Attachment #8991604 - Flags: approval-calendar-esr+
Attachment #8991604 - Flags: approval-calendar-beta+
Attachment #8991606 - Flags: review?(makemyday)
Attachment #8991606 - Flags: approval-calendar-esr+
Attachment #8991606 - Flags: approval-calendar-beta+
Attachment #8991607 - Flags: review?(makemyday)
Attachment #8991607 - Flags: approval-calendar-esr+
Attachment #8991607 - Flags: approval-calendar-beta+
Attached patch Update minVersion - v1 β€” β€” Splinter Review
Attachment #8991608 - Flags: review?(makemyday)
Attachment #8991608 - Flags: approval-calendar-esr+
Attachment #8991608 - Flags: approval-calendar-beta+
Attached patch Fix strict and deprecated warnings - v1 (obsolete) β€” β€” Splinter Review
Attachment #8991609 - Flags: review?(makemyday)
Attachment #8991609 - Flags: approval-calendar-esr+
Attachment #8991609 - Flags: approval-calendar-beta+
Attachment #8991609 - Flags: review?(makemyday) → review+
Attachment #8991608 - Flags: review?(makemyday) → review+
Comment on attachment 8991607 [details] [diff] [review]
Fix reminder overlay styles - v1

Review of attachment 8991607 [details] [diff] [review]:
-----------------------------------------------------------------

Since you're requiring 52 as minimum requirement in the other patch, don't you need to shim cal.alarms.calculateAlarmOffset(item, reminder)? r+ with that checked.
Attachment #8991607 - Flags: review?(makemyday) → review+
Attachment #8991606 - Flags: review?(makemyday) → review+
Comment on attachment 8991604 [details] [diff] [review]
Increase browserRequest size - v1

Review of attachment 8991604 [details] [diff] [review]:
-----------------------------------------------------------------

There are other occurrence [1], that probably need to be adapted as well if a resizing is required - r+ with that checkd.

[1] https://searchfox.org/comm-central/search?q=symbol:%23requestWindowFeatures&redirect=false
Attachment #8991604 - Flags: review?(makemyday) → review+
Good point. This didn't show since calAlarmUtils is loaded beforehand, but best to be thorough.

The best order to land this now is (apply bottom to top)

Bug 1475224 - Update gdata minVersion to Thunderbird 52. r=MakeMyDay
Bug 1475224 - Fix gdata reminder dialog styles and overlay. r=MakeMyDay
Bug 1475224 - Fix gdata calendar properties dialog overlay. r=MakeMyDay
Bug 1475224 - Fix strict and deprecated warnings in the gdata provider. r=MakeMyDay
Bug 1475224 - Increase browserRequest size to adapt for Google's new design. r=MakeMyDay
Bug 1475221 - Adapt the Provider for event in a tab. r=MakeMyDay
Attachment #8991609 - Attachment is obsolete: true
Attachment #8995835 - Flags: review+
Attachment #8995835 - Flags: approval-calendar-esr+
Attachment #8995835 - Flags: approval-calendar-beta+
Might as well change all the sizes. r?jorgk for the mailnews change, then this can be pushed. No tests running for gdata anyway so I don't think we need a try.
Attachment #8991604 - Attachment is obsolete: true
Attachment #8995837 - Flags: review?(jorgk)
Attachment #8995837 - Flags: approval-calendar-esr+
Attachment #8995837 - Flags: approval-calendar-beta+
Comment on attachment 8995837 [details] [diff] [review]
Increase browserRequest size - v2

Looks OK. Hopefully no one runs this on a netbook with a screen height of 600px, like I used to have ;-(
Attachment #8995837 - Flags: review?(jorgk) → review+
I'll land this as per comment #8, oh, what does "apply bottom to top" mean? The patches seem to apply in any order. I applied the minVersion first.
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dd97ca4b579c
Increase browserRequest size to adapt for Google's new design. r=MakeMyDay,jorgk
https://hg.mozilla.org/comm-central/rev/f679adf75824
Fix strict and deprecated warnings in the gdata provider. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/2cd19d35df02
Fix gdata calendar properties dialog overlay. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/5b2355a860ad
Fix gdata reminder dialog styles and overlay. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/66eb55289609
Update gdata minVersion to Thunderbird 52. r=MakeMyDay
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 6.5
Attached patch 1475224-linting.patch β€” β€” Splinter Review
Had to fix some linting errors, I hope I got this right.
Attachment #8995846 - Flags: review?(philipp)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/75492d81b44d
Fix linting errors. rs=bustage-fix DONTBUILD
Attachment #8995846 - Flags: review?(philipp) → review+
Attachment #8991606 - Flags: approval-calendar-beta+
Attachment #8991607 - Flags: approval-calendar-beta+
Attachment #8991608 - Flags: approval-calendar-beta+
Attachment #8995835 - Flags: approval-calendar-beta+
Attachment #8995837 - Flags: approval-calendar-beta+
Attachment #8991604 - Flags: approval-calendar-beta+
Attachment #8991609 - Flags: approval-calendar-beta+
Are we by chance going to have something to test come TB 60.1?
You need to log in before you can comment on or make changes to this bug.