1475224 - Various fixes to make the Provider ready for Lightning 6.2 / Thunderbird 60

Status: RESOLVED FIXED

(Calendar :: Provider: GData, enhancement)

Description

[Philipp Kewisch [:Fallen][📱📆]]

There are a few issues that need to be fixed for the new provider release. They are all fairly small issues, so I am gathering them here.

Comment 1

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Increase browserRequest size - v1

Comment 2

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix properties dialog overlay - v1

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix reminder overlay styles - v1

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Update minVersion - v1

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix strict and deprecated warnings - v1

Comment 6

[[:MakeMyDay]]

Comment on attachment 8991607 [details] [diff] [review]
Fix reminder overlay styles - v1

Review of attachment 8991607 [details] [diff] [review]:
-----------------------------------------------------------------

Since you're requiring 52 as minimum requirement in the other patch, don't you need to shim cal.alarms.calculateAlarmOffset(item, reminder)? r+ with that checked.

Comment 7

[[:MakeMyDay]]

Comment on attachment 8991604 [details] [diff] [review]
Increase browserRequest size - v1

Review of attachment 8991604 [details] [diff] [review]:
-----------------------------------------------------------------

There are other occurrence [1], that probably need to be adapted as well if a resizing is required - r+ with that checkd.

[1] https://searchfox.org/comm-central/search?q=symbol:%23requestWindowFeatures&redirect=false

Comment 8

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix strict and deprecated warnings - v2

Good point. This didn't show since calAlarmUtils is loaded beforehand, but best to be thorough.

The best order to land this now is (apply bottom to top)

Bug 1475224 - Update gdata minVersion to Thunderbird 52. r=MakeMyDay
Bug 1475224 - Fix gdata reminder dialog styles and overlay. r=MakeMyDay
Bug 1475224 - Fix gdata calendar properties dialog overlay. r=MakeMyDay
Bug 1475224 - Fix strict and deprecated warnings in the gdata provider. r=MakeMyDay
Bug 1475224 - Increase browserRequest size to adapt for Google's new design. r=MakeMyDay
Bug 1475221 - Adapt the Provider for event in a tab. r=MakeMyDay

Comment 9

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Increase browserRequest size - v2

Might as well change all the sizes. r?jorgk for the mailnews change, then this can be pushed. No tests running for gdata anyway so I don't think we need a try.

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8995837 [details] [diff] [review]
Increase browserRequest size - v2

Looks OK. Hopefully no one runs this on a netbook with a screen height of 600px, like I used to have ;-(

Comment 11

[Jorg K (CEST = GMT+2)]

I'll land this as per comment #8, oh, what does "apply bottom to top" mean? The patches seem to apply in any order. I applied the minVersion first.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd97ca4b579c
Increase browserRequest size to adapt for Google's new design. r=MakeMyDay,jorgk
https://hg.mozilla.org/comm-central/rev/f679adf75824
Fix strict and deprecated warnings in the gdata provider. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/2cd19d35df02
Fix gdata calendar properties dialog overlay. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/5b2355a860ad
Fix gdata reminder dialog styles and overlay. r=MakeMyDay
https://hg.mozilla.org/comm-central/rev/66eb55289609
Update gdata minVersion to Thunderbird 52. r=MakeMyDay

Comment 13

[Jorg K (CEST = GMT+2)]

Attachment: 1475224-linting.patch

Had to fix some linting errors, I hope I got this right.

Comment 14

[Jorg K (CEST = GMT+2)]

TB 60 ESR, Cal 6.2:
https://hg.mozilla.org/releases/comm-esr60/rev/66c0e5f6fc3a
https://hg.mozilla.org/releases/comm-esr60/rev/f6d167eea841
https://hg.mozilla.org/releases/comm-esr60/rev/6ced8e2fbc6e
https://hg.mozilla.org/releases/comm-esr60/rev/9b0e5cce584b
https://hg.mozilla.org/releases/comm-esr60/rev/148c2ffcec24
https://hg.mozilla.org/releases/comm-esr60/rev/1d0a66f5d8f0

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/75492d81b44d
Fix linting errors. rs=bustage-fix DONTBUILD

Comment 16

[Arthur K. (he/him)]

Are we by chance going to have something to test come TB 60.1?