1475252 - Update webrender to 88dab3f611b05516c1c54a7cb35813b796b08584

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1474300 +++

I'm filing this as a placeholder bug for the next webrender update. I may be running a cron script [1] that does try pushes with webrender update attempts, so that we can track build/test breakages introduced by webrender on a rolling basis. This bug will hold the try push links as well as dependencies filed for those breakages, so that we have a better idea going into the update of what needs fixing. I might abort the cron job because once things get too far out of sync it's hard to fully automate fixing all the breakages.

When we are ready to actually land the update, we can rename this bug and use it for the update, and then file a new bug for the next "future update".

[1] https://github.com/staktrace/moz-scripts/blob/master/try-latest-webrender.sh

Comment 1

[Kartikaya Gupta (email:[e-mail])]

WR @ ea3c348684a98e83df2c1fba3f9ad2c6e4b402b9

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1e04caf2f105afcbfc925ebfc33d60d1f7db4b3d
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4991298809e591625259469776e2599f08950b52

WR @ c540acf0990f8a0cbf9429e7085c7cc3b6901add

https://treeherder.mozilla.org/#/jobs?repo=try&revision=99c2023a9d6d1a7d8d48caa3ea03cc717441a3e9

These are green but windows has a backlog so reftests/talos haven't run there yet.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

WR @ c540acf0990f8a0cbf9429e7085c7cc3b6901add

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d7aa5ee8c44fe436eec76079fe07b74a12f0506
https://treeherder.mozilla.org/#/jobs?repo=try&revision=749e4c99203bab969b01d8eb857151885e449090

Green

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c29aa47dde85237638b2b3c6f2af7bda8f5167ff

A few Wr2 unexpected-passes, which is bug 1475909.

WR @ 915ec3a047d5991284bf5655df3b043e6b9756fa

https://treeherder.mozilla.org/#/jobs?repo=try&revision=623ebb96f1ffb1188b755a34064fb7b492aee1c5

Green

Comment 3

[Kartikaya Gupta (email:[e-mail])]

WR @ 526be269181ce8fa24ab762d13bd4ffbdd799971

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4cc0ba2f21b99611d06f0cebbca993ced56fb862

Green

WR @ de0ef914cd747986c5c49c33aa61897f650d224c

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c1d649180a3f93fdf5bb35989d9b5bfc758ba9f

Green

Comment 4

[Kartikaya Gupta (email:[e-mail])]

WR @ 88dab3f611b05516c1c54a7cb35813b796b08584

https://treeherder.mozilla.org/#/jobs?repo=try&revision=388b73e383c837f0219973f760a5343530f7fe22

Green

Comment 5

[Kartikaya Gupta (email:[e-mail])]

WR @ 41ceda1754a950bcc2127059ab1dff728eb40ab6

https://treeherder.mozilla.org/#/jobs?repo=try&revision=04c6bc71074245fa9d8438a78922e71fbd36dff7

That's not green. Regression range:

*   41ceda17 Auto merge of #2907 - servo:gleam, r=nical
|\
| * 6d3fa14f (origin/gleam) Update gleam to 0.6
* |   e6635df8 Auto merge of #2905 - gw3583:cpu-opt, r=kvark
|\ \
| |/
|/|
| * d40a73dd Remove some redundant rectangle transform and union code.
*   89c79c22 Auto merge of #2903 - zakorgy:winit-dpi, r=kvark
|\
| * 23d3cae5 Use dpi from winit instead of glutin
* 9117f291 Auto merge of #2904 - Eijebong:euclid, r=nical
* 29033572 Bump rust's version to fix tests
* 2a6676d0 Update euclid to 0.18

judging by the panic stack most likely suspect is servo/webrender#2905

Comment 6

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> 
> judging by the panic stack most likely suspect is servo/webrender#2905

There's a try push in that PR and it's green. I'll do some more try pushes to verify.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1475252 - Update webrender to 88dab3f611b05516c1c54a7cb35813b796b08584.

Review commit: https://reviewboard.mozilla.org/r/257832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257832/

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1475252 - Update Cargo lockfiles, re-vendor rust dependencies, and re-generate FFI header.

Review commit: https://reviewboard.mozilla.org/r/257834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257834/

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1475252 - Update for API changes in WR PR 2871.

This change has WrClipId contain the ClipId type (except for clip
chains, which are handled separately) in the least significant bit of
the size_t. On 32-bit systems this limits the number of clip and spatial
nodes to 2,147,483,648 which is likely more than what WebRender can
handle.

Review commit: https://reviewboard.mozilla.org/r/257836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257836/

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1475252 - Update for API change in WR PR 2893.

Review commit: https://reviewboard.mozilla.org/r/257838/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257838/

Comment 11

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8993014 [details]
Bug 1475252 - Update for API changes in WR PR 2871.

https://reviewboard.mozilla.org/r/257836/#review264744

Carrying r+ from bug 1474300 on this patch

Comment 12

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8993012 [details]
Bug 1475252 - Update webrender to 88dab3f611b05516c1c54a7cb35813b796b08584.

https://reviewboard.mozilla.org/r/257832/#review264762

Comment 13

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8993015 [details]
Bug 1475252 - Update for API change in WR PR 2893.

https://reviewboard.mozilla.org/r/257838/#review264764

Comment 14

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8993013 [details]
Bug 1475252 - Update Cargo lockfiles, re-vendor rust dependencies, and re-generate FFI header.

https://reviewboard.mozilla.org/r/257834/#review264766

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6069dcebdbeb
Update webrender to 88dab3f611b05516c1c54a7cb35813b796b08584. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/2fc39b0ceb6a
Update Cargo lockfiles, re-vendor rust dependencies, and re-generate FFI header. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/94ba9ae35230
Update for API changes in WR PR 2871. r=kats
https://hg.mozilla.org/integration/autoland/rev/b37ffbaae53b
Update for API change in WR PR 2893. r=jrmuizel

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6069dcebdbeb
https://hg.mozilla.org/mozilla-central/rev/2fc39b0ceb6a
https://hg.mozilla.org/mozilla-central/rev/94ba9ae35230
https://hg.mozilla.org/mozilla-central/rev/b37ffbaae53b