Turn off async launch until we understand how to handle errors (and remove intentional crashes)

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P1
normal
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: jld, Assigned: jld)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

1. We're no longer getting any useful debugging information from the intentional crashes added in bug 1461459; we're just annoying Nightly users and making them not want to help us.  Those should be removed.

2. Async launch should be turned off completely until we understand how to handle errors.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8992537 [details]
Bug 1475382 - Remove debugging crashes added in bug 1461459.

https://reviewboard.mozilla.org/r/257392/#review264406
Attachment #8992537 - Flags: review?(spohl.mozilla.bugs) → review+

Comment 4

10 months ago
mozreview-review
Comment on attachment 8992538 [details]
Bug 1475382 - Turn off async content process launching, pending better error handling.

https://reviewboard.mozilla.org/r/257394/#review264408

What's the plan on figuring out the remaining issues?
Attachment #8992538 - Flags: review?(spohl.mozilla.bugs) → review+
See Also: → 1476811
See Also: → 1476816
(In reply to Stephen A Pohl [:spohl] from comment #4)
> What's the plan on figuring out the remaining issues?

I filed some bugs.  I do think we'll need to be able to handle errors somehow, but it's not impossible that we'd be able to get the DOM to understand asynchronous launching instead of the current attempt at to do it semi-transparently within IPC.

Comment 6

10 months ago
Pushed by jedavis@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c10f1db88f0
Remove debugging crashes added in bug 1461459. r=spohl
https://hg.mozilla.org/integration/autoland/rev/99011a1e3da5
Turn off async content process launching, pending better error handling. r=spohl

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7c10f1db88f0
https://hg.mozilla.org/mozilla-central/rev/99011a1e3da5
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.