1475382 - Turn off async launch until we understand how to handle errors (and remove intentional crashes)

Status: RESOLVED FIXED

(Core :: IPC, enhancement, P1)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

1. We're no longer getting any useful debugging information from the intentional crashes added in bug 1461459; we're just annoying Nightly users and making them not want to help us.  Those should be removed.

2. Async launch should be turned off completely until we understand how to handle errors.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1475382 - Remove debugging crashes added in bug 1461459.

These are no longer providing useful information.  There are still a
noticeable number of failures on Windows, but we've narrowed them down to
within SandboxBroker::LaunchApp.

Review commit: https://reviewboard.mozilla.org/r/257392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257392/

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1475382 - Turn off async content process launching, pending better error handling.

At the moment this isn't actually async because we immediately require
the pid and block on launch anyway.  It also crashes the entire browser
on otherwise recoverable launch errors, because code that wants the pid
isn't set up to handle that operation failing.

Review commit: https://reviewboard.mozilla.org/r/257394/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257394/

Comment 3

[Stephen A Pohl [:spohl]]

Comment on attachment 8992537 [details]
Bug 1475382 - Remove debugging crashes added in bug 1461459.

https://reviewboard.mozilla.org/r/257392/#review264406

Comment 4

[Stephen A Pohl [:spohl]]

Comment on attachment 8992538 [details]
Bug 1475382 - Turn off async content process launching, pending better error handling.

https://reviewboard.mozilla.org/r/257394/#review264408

What's the plan on figuring out the remaining issues?

Comment 5

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Stephen A Pohl [:spohl] from comment #4)
> What's the plan on figuring out the remaining issues?

I filed some bugs.  I do think we'll need to be able to handle errors somehow, but it's not impossible that we'd be able to get the DOM to understand asynchronous launching instead of the current attempt at to do it semi-transparently within IPC.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c10f1db88f0
Remove debugging crashes added in bug 1461459. r=spohl
https://hg.mozilla.org/integration/autoland/rev/99011a1e3da5
Turn off async content process launching, pending better error handling. r=spohl

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/7c10f1db88f0
https://hg.mozilla.org/mozilla-central/rev/99011a1e3da5