1475385 - unprefix -moz-column-* in our copies of w3c-submitted reftests, so we can remove unprefixing logic from sync-tests.sh

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Daniel Holbert [:dholbert]]

We have a few -moz-column-* usages our copies of w3c-submitted reftests:
https://searchfox.org/mozilla-central/search?q=-moz-column&path=w3c-css%2Fsubmitted

We should unprefix these, now that we support unprefixed column-* properties (as of bug 1300895).

Once we've got no more -moz-column-* in that directory, then I think we can update https://dxr.mozilla.org/mozilla-central/source/testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/sync-tests.sh#15 to remove the moz-column substitution there.

TYLin, I think you're looking at some multicol stuff -- perhaps you can take this?

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Sure. I can take this.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1475385 - Unprefix -moz-column-* in w3c-submitted reftests.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I guess sync-test.sh should be fixed directly on https://github.com/web-platform-tests/wpt. I'll do that after this bug is fixed.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #3)
> I guess sync-test.sh should be fixed directly on
> https://github.com/web-platform-tests/wpt. I'll do that after this bug is
> fixed.

I'll bet we can fix our in-tree copy and it'll get synced upstream.  We do that for tests, at least, and I think we've got processes in place for bidirectional synchronization.

Comment 5

[Phabricator Automation]

Comment on attachment 8991770 [details]
Bug 1475385 - Unprefix -moz-column-* in w3c-submitted reftests.

Daniel Holbert [:dholbert] has approved the revision.

https://phabricator.services.mozilla.com/D2112

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f05fd6acc53
Unprefix -moz-column-* in w3c-submitted reftests. r=dholbert

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Daniel Holbert [:dholbert] from comment #4)
> (In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #3)
> > I guess sync-test.sh should be fixed directly on
> > https://github.com/web-platform-tests/wpt. I'll do that after this bug is
> > fixed.
> 
> I'll bet we can fix our in-tree copy and it'll get synced upstream.  We do
> that for tests, at least, and I think we've got processes in place for
> bidirectional synchronization.

Fixing it directly in web-platform-tests has the advantage that the stuff in w3c/submitted can be landed immediately, rather than waiting for the sync (although if the sync is fast, that's not an issue).

Comment 8

[Daniel Holbert [:dholbert]]

Ah, thanks for clarifying. That's useful to know, for timing the changes around bug 1475645.  Perhaps it's best for morgan to make those changes in the upstream WPT repo, then (after tylin's changes here are synced), so that she can then land her multicol tests immediately.

Anyway, I'll follow up more on bug 1475645.

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2f05fd6acc53

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/11989 for changes under testing/web-platform/tests

Comment 11

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

Marking this as qe-verify -, per comment 10.