Closed Bug 1475903 Opened 6 years ago Closed 6 years ago

Introduce XPCOM mozIDOMLocalization API

Categories

(Core :: Internationalization, enhancement, P2)

Product:
Core
Component:
Internationalization
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

Bug 1475903 - Add mozIDOMLocalization API.
59 bytes, text/x-review-board-request
mossop
: review+
Details
DOMLocalization is currently exposed via JSM module. It makes it very convenient to be used from JS, but impossible to use it from C++. In order to expose document.l10n via WebIDL (bug 1455649) we need an XPCOM component.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8992237 [details] Bug 1475903 - Add mozIDOMLocalization API. https://reviewboard.mozilla.org/r/257120/#review265830 Sorry it took me so long to get to this.
Attachment #8992237 - Flags: review?(dtownsend) → review+
Thanks Dave! I'll rebase on top of bug 1474369 to get the sweet array behavior right.
Depends on: 1474369
The dependency has landed and the code works now! :)
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fbbb0327f0f1 Add mozIDOMLocalization API. r=mossop
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfaeacf41b77 Add mozIDOMLocalization API. r=mossop
Backed out for causing leaks at nsTArray_base. Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&tochange=3b38d38e2ff16fc7828c2766af0ce3271caacce7&fromchange=bfaeacf41b77bcc25f8792cbc83aea45998ab971&filter-searchStr=c2&selectedJob=191535284 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191535284&repo=autoland&lineNumber=17003 Backout link: https://hg.mozilla.org/integration/autoland/rev/3b38d38e2ff16fc7828c2766af0ce3271caacce7 [task 2018-08-02T07:35:26.035Z] 07:35:26 ERROR - TEST-UNEXPECTED-FAIL | leakcheck | default process: 32 bytes leaked (nsTArray_base) [task 2018-08-02T07:35:26.036Z] 07:35:26 INFO - runtests.py | Running tests: end. [task 2018-08-02T07:35:26.052Z] 07:35:26 INFO - Buffered messages finished [task 2018-08-02T07:35:26.054Z] 07:35:26 INFO - Running manifest: js/xpconnect/tests/chrome/chrome.ini [task 2018-08-02T07:35:26.171Z] 07:35:26 INFO - Setting pipeline to PAUSED ... [task 2018-08-02T07:35:26.172Z] 07:35:26 INFO - Pipeline is PREROLLING ... [task 2018-08-02T07:35:26.173Z] 07:35:26 INFO - Pipeline is PREROLLED ... [task 2018-08-02T07:35:26.174Z] 07:35:26 INFO - Setting pipeline to PLAYING ... [task 2018-08-02T07:35:26.174Z] 07:35:26 INFO - New clock: GstSystemClock [task 2018-08-02T07:35:26.211Z] 07:35:26 INFO - Got EOS from element "pipeline0". [task 2018-08-02T07:35:26.212Z] 07:35:26 INFO - Execution ended after 0:00:00.033499147 [task 2018-08-02T07:35:26.213Z] 07:35:26 INFO - Setting pipeline to PAUSED ... [task 2018-08-02T07:35:26.214Z] 07:35:26 INFO - Setting pipeline to READY ... [task 2018-08-02T07:35:26.215Z] 07:35:26 INFO - (gst-launch-1.0:7105): GStreamer-CRITICAL **: gst_object_unref: assertion '((GObject *) object)->ref_count > 0' failed [task 2018-08-02T07:35:26.216Z] 07:35:26 INFO - Setting pipeline to NULL ... [task 2018-08-02T07:35:26.217Z] 07:35:26 INFO - Freeing pipeline ... [task 2018-08-02T07:35:26.699Z] 07:35:26 INFO - pk12util: PKCS12 IMPORT SUCCESSFUL [task 2018-08-02T07:35:26.869Z] 07:35:26 INFO - MochitestServer : launching [u'/builds/worker/workspace/build/tests/bin/xpcshell', '-g', '/builds/worker/workspace/build/application/firefox', '-f', '/builds/worker/workspace/build/tests/bin/components/httpd.js', '-e', "const _PROFILE_PATH = '/tmp/tmpsGR6pM.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', '/builds/worker/workspace/build/tests/mochitest/server.js'] [task 2018-08-02T07:35:26.869Z] 07:35:26 INFO - runtests.py | Server pid: 7128 [task 2018-08-02T07:35:26.952Z] 07:35:26 INFO - runtests.py | Websocket server pid: 7132 [task 2018-08-02T07:35:27.114Z] 07:35:27 INFO - runtests.py | SSL tunnel pid: 7142 [task 2018-08-02T07:35:27.239Z] 07:35:27 INFO - Couldn't convert chrome URL: chrome://branding/locale/brand.properties [task 2018-08-02T07:35:27.241Z] 07:35:27 INFO - [7128, Main Thread] WARNING: Could not get the program name for a cubeb stream.: 'NS_SUCCEEDED(rv)', file /builds/worker/workspace/build/src/dom/media/CubebUtils.cpp, line 353 [task 2018-08-02T07:35:27.265Z] 07:35:27 INFO - runtests.py | Running with e10s: False [task 2018-08-02T07:35:27.266Z] 07:35:27 INFO - runtests.py | Running tests: start.
Depends on: 1480500
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/073983e062f7 Add mozIDOMLocalization API. r=mossop
https://hg.mozilla.org/mozilla-central/rev/073983e062f7
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/0dc99a856ed3 Port bug 1475903 to TB: add mozDOMLocalization.js/manifest to package manifest. rs=bustage-fix
Flags: needinfo?(gandalf)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: