1476009 - [Static Analysis] DEAD_STORE error in storage/mozStorageHelper.h

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect, P3)

Description

[Robert Bartlensky [:rbartlensky]]

storage/mozStorageHelper.h:157: error: DEAD_STORE
  The value written to &rv (type int) is never used.
  155.       // TODO (bug 1062823): from Sqlite 3.7.11 on, rollback won't ever return
  156.       // a busy error, so this handling can be removed.
  157. >     nsresult rv = NS_OK;
  158.       do {
  159.         rv = mConnection->ExecuteSimpleSQL(NS_LITERAL_CSTRING("ROLLBACK"));

Comment 1

[Robert Bartlensky [:rbartlensky]]

Attachment: Bug 1476009: Remove unnecessary initialization.

Review commit: https://reviewboard.mozilla.org/r/257266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257266/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8992391 [details]
Bug 1476009: Remove unnecessary initialization.

https://reviewboard.mozilla.org/r/257266/#review264340

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44fd25e3d484
Remove unnecessary initialization. r=mak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/44fd25e3d484