52 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
[Affected versions]: - Firefox 61.0+ [Affected Platforms]: - All Windows - All Mac - All Linux [Prerequisites]: - Have a clean new Firefox profile. - Have the set-up for the "Personalization1" variant configured (https://goo.gl/cL4Ue3). - Ensure ability to see SPOCs is checked in about:preferences#home - Ensure that the entry for browser.newtabpage.activity-stream.feeds.section.topstories.spoc.impressions is blank. [Steps to reproduce]: 1. Start the browser with the profile from prerequisites. 2. Open 110 Tabs [Expected result]: - Should see 500 tabs / day with SPOCs from the same campaign id [Actual results]: - A non-sponsored card is displayed after the 101st SPOC impression - The browser setting browser.newtabpage.activity-stream.feeds.section.topstories.spoc.impressions has an array that stops increasing after the 100th impression of the same campaign.
The original implementation from https://github.com/mozilla/activity-stream/pull/3710 has a hardcoded 100 limit: +const MAX_LIFETIME_CAP = 100; // Guard against misconfiguration on the server Is there something that actually wants more than 100? Perhaps this just needs to be increased?
Ah, thank you for letting me know about the hardcoded limit. Yes, I think increasing it to 500 should suffice.
Hi Tushar, can you add some details around why this increase is needed, and if there's any particular timeframe required? Just to help us prioritize.
Hi Jenn - of course, sorry for not including it initially. Originally, we had much tighter restrictions on frequency caps. Now that we've gotten some insight that loosening them somewhat didn't have an impact on Fx retention, this limit is potentially more of an issue (while still a bit of an edge case). The reason I noticed this limit at all was that we've been testing some different personalization configs in a Shield study and I ran into this cap. It would be ideal if we could get this addressed in the next release.
Assignee: nobody → sdowne
Iteration: --- → 63.3 - Aug 6
Priority: -- → P1
Created attachment 8997038 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4283
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/7de1abf072c63cda5d807cef4d91c02dde673f5f Fixes Bug 1476045 - SPOCs stop showing after seeing 100 impressions of the same campaign https://github.com/mozilla/activity-stream/commit/da6c3838c0745de4bde8c6564ee349b7a8e5e5c5 Merge pull request #4283 from ScottDowne/t-1476045 Fixes Bug 1476045 - SPOCs stop showing after seeing 100 impressions o…
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Iteration: 63.3 - Aug 6 → 63.4 - Aug 20
status-firefox63: --- → fixed
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.