1476052 - Bugzilla mishandles diff attachments that are UTF-8 and contain U+FFFF

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, enhancement)

Description

[Jeff Walden [:Waldo]]

Attachment: minimal.diff

Uploading this to Bugzilla as a patch and hitting the Diff or Splinter links for this attachment will complain about internal errors about malformed UTF-8.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

it's specifically the \x{ffff}.

The problem is that U+FFFF isn't a character, so when we want to character operations on the string of that attachment an error is raised. This has actually been fixed for something like a decade but we're still running perl 5.10.

I'm going to replace it with U+FFFD until we can upgrade perl.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: PR

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Instead of replacing U+FFFF I've just made it work. Turned out to be pretty easy.