1476128 - No mobile data is coming for HIDDEN_VIEWPORT_OVERFLOW_TYPE

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

See bug 1423017 comment 56.

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Attachment: patch, r=botond

This has been r+ed in bug 1423017 comment 59.

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8992485 [details] [diff] [review]
patch, r=botond

Approval Request Comment
[Feature/Bug causing the regression]: bug 1423017
[User impact if declined]: we may not be able to collect enough information for evaluating solution of bug 1423013
[Is this code covered by automated tests?]: n/a
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: just a telemetry item change
[String changes made/needed]: n/a

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/70d07e42dcd4
Have HIDDEN_VIEWPORT_OVERFLOW_TYPE recorded on main process as well. r=botond

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/70d07e42dcd4

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

How can we verify this in 63 before uplift? Is the telemetry data coming through now ? It looks like the first try in bug 1423017 didn't work. So let's verify this new fix before we land this on beta.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Telemetry data seems to be lagging at the moment. The latest data is from July 16, so there is no clue currently. I'll continue monitoring the result and report back as soon as I see new data.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

It seems data is coming now: https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2018-07-17&keys=__none__!__none__!__none__&max_channel_version=nightly%252F63&measure=HIDDEN_VIEWPORT_OVERFLOW_TYPE&min_channel_version=null&processType=parent&product=Fennec&sanitize=1&sort_keys=submissions&start_date=2018-07-17&table=0&trim=1&use_submission_date=0

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8992485 [details] [diff] [review]
patch, r=botond

Tweak to telemetry to make sure we get Fennec data. 
I'll take Xidorn's confirmation that the data is flowing, as enough verification!

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/63fefabe7b60