1476131 - [wpt-sync] Sync PR 12004 - Adding explicit call to session.end for WebDriver delete session tests

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 12004 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12004
Details from upstream follow.

Jim Evans <[e-mail]> wrote:
>  Adding explicit call to session.end for WebDriver delete session tests
>  
>  For the "delete session" command tests, the recent changes to the fixture
>  to create and delete sessions are bypassed. This means that at the end of
>  each delete session test, the harness thinks a valid session still exists.
>  Making an explicit call to `session.end()` at the end of each test will
>  put the tracking variables in the correct state for the harness to start a
>  new session with the next test.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=72acbfbb956e17d92abf3f18539aa67640fef804

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b96518a6734c009b383d1f2caad3ea9d1c210b5

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 2 subtests
OK     : 1
FAIL   : 2

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/webdriver/tests/delete_session/delete.py
    test_null_response_value: FAIL

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I'm not sure if the solution as merged to the upstream repository is correct. I asked Jim on https://github.com/web-platform-tests/wpt/pull/12004 for feedback.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It has been discussed on Github, and bug 1477978 has been filed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf824a9cfb6
[wpt PR 12004] - Adding explicit call to session.end for WebDriver delete session tests, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e14f398bdd78
[wpt PR 12004] - Update wpt metadata, a=testonly

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4bf824a9cfb6
https://hg.mozilla.org/mozilla-central/rev/e14f398bdd78