Closed Bug 1476131 Opened 4 years ago Closed 4 years ago
[wpt-sync] Sync PR 12004 - Adding explicit call to session
.end for Web Driver delete session tests
Sync web-platform-tests PR 12004 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/12004 Details from upstream follow. Jim Evans <email@example.com> wrote: > Adding explicit call to session.end for WebDriver delete session tests > > For the "delete session" command tests, the recent changes to the fixture > to create and delete sessions are bypassed. This means that at the end of > each delete session test, the harness thinks a valid session still exists. > Making an explicit call to `session.end()` at the end of each test will > put the tracking variables in the correct state for the harness to start a > new session with the next test.
4 years ago
Component: web-platform-tests → geckodriver
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b96518a6734c009b383d1f2caad3ea9d1c210b5
Ran 1 tests and 2 subtests OK : 1 FAIL : 2 Existing tests that now have a worse result (e.g. they used to PASS and now FAIL): /webdriver/tests/delete_session/delete.py test_null_response_value: FAIL
I'm not sure if the solution as merged to the upstream repository is correct. I asked Jim on https://github.com/web-platform-tests/wpt/pull/12004 for feedback.
It has been discussed on Github, and bug 1477978 has been filed.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf824a9cfb6 [wpt PR 12004] - Adding explicit call to session.end for WebDriver delete session tests, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e14f398bdd78 [wpt PR 12004] - Update wpt metadata, a=testonly
You need to log in before you can comment on or make changes to this bug.