Fix TestFileCleanupController after the Oreo migration

RESOLVED FIXED in Firefox 63

Status

()

defect
RESOLVED FIXED
Last year
Last year

People

(Reporter: petru, Assigned: petru)

Tracking

(Blocks 1 bug)

unspecified
Firefox 63
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

After Bug 1407046 which migrated the IntentServices to JobIntentServices two tests in TestFileCleanupController are failing because they check if a regular service was started or not, something that isn't possible after the migration.

Example of failed test - https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e84a273a0e973156de3ff4c5e7d3771ccb512ec8&selectedJob=188457048
Blocks: 1407046
Assignee: nobody → petru.lingurar
Status: NEW → ASSIGNED
Pushed a patch that also migrates two test classes to using JobScheduler instead of dependending on the Service behavior.

Ran a try build with this patch applied on top of the Oreo patches and everything seems fine now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f2f362739b7de0446e404b2173df1693fa43e02
Merged the two new tests from TestTelemetryUploadAllPingsImmediatelyScheduler from the first version of the patch into one single test, like it was before migrating the tests to use JobScheduler. 
I think this makes the test easier to understand and more useful than in the first patch version which enqueued work using JobIntentService.enqueue(..).

Ran a new try build to make sure there will be no problems - https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b208545cfe964fa54931badbcedd0664cd42297
Attachment #8992900 - Flags: review?(sdaswani) → review?(nchen)
Attachment #8992901 - Flags: review?(sdaswani) → review?(nchen)
Comment on attachment 8992900 [details]
Bug 1476237 - Fix TestFileCleanupController after the Oreo migration;

https://reviewboard.mozilla.org/r/257730/#review264778
Attachment #8992900 - Flags: review?(nchen) → review+
Comment on attachment 8992901 [details]
Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration;

https://reviewboard.mozilla.org/r/257732/#review264782
Attachment #8992901 - Flags: review?(nchen) → review+
Keywords: checkin-needed
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8517368556d1
Fix TestFileCleanupController after the Oreo migration; r=jchen
https://hg.mozilla.org/integration/autoland/rev/9582213d1360
Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r=jchen
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8517368556d1
https://hg.mozilla.org/mozilla-central/rev/9582213d1360
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Blocks: android-o
You need to log in before you can comment on or make changes to this bug.