1476237 - Fix TestFileCleanupController after the Oreo migration

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

After Bug 1407046 which migrated the IntentServices to JobIntentServices two tests in TestFileCleanupController are failing because they check if a regular service was started or not, something that isn't possible after the migration.

Example of failed test - https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e84a273a0e973156de3ff4c5e7d3771ccb512ec8&selectedJob=188457048

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1476237 - Fix TestFileCleanupController after the Oreo migration;

This tests verified if a Service was started or nor. After the IntentServices
migration to JobIntentService this checks would not work anymore.

To keep the same test logic they will now check if JobScheduler has any
scheduled jobs.

Removed testStartIfReadyDoesNotRunTwiceInSuccession() because JobScheduler
already guarantees no two identical jobs can be scheduled in parallel.

Review commit: https://reviewboard.mozilla.org/r/257730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257730/

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration;

Refactored the previous test which verified if a Service was started and with
which Intent into two tests:
- one that will check if the right JobIntentService was enqueued and
- one which will check the enqueued Intent of work.

Review commit: https://reviewboard.mozilla.org/r/257732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257732/

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Pushed a patch that also migrates two test classes to using JobScheduler instead of dependending on the Service behavior.

Ran a try build with this patch applied on top of the Oreo patches and everything seems fine now:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f2f362739b7de0446e404b2173df1693fa43e02

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8992900 [details]
Bug 1476237 - Fix TestFileCleanupController after the Oreo migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257730/diff/1-2/

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 8992901 [details]
Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257732/diff/1-2/

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Merged the two new tests from TestTelemetryUploadAllPingsImmediatelyScheduler from the first version of the patch into one single test, like it was before migrating the tests to use JobScheduler. 
I think this makes the test easier to understand and more useful than in the first patch version which enqueued work using JobIntentService.enqueue(..).

Ran a new try build to make sure there will be no problems - https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b208545cfe964fa54931badbcedd0664cd42297

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992900 [details]
Bug 1476237 - Fix TestFileCleanupController after the Oreo migration;

https://reviewboard.mozilla.org/r/257730/#review264778

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992901 [details]
Bug 1476237 - Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration;

https://reviewboard.mozilla.org/r/257732/#review264782

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8517368556d1
Fix TestFileCleanupController after the Oreo migration; r=jchen
https://hg.mozilla.org/integration/autoland/rev/9582213d1360
Fix TestTelemetryUploadAllPingsImmediatelyScheduler the after Oreo migration; r=jchen

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/8517368556d1
https://hg.mozilla.org/mozilla-central/rev/9582213d1360

Comment 11

[Intermittent Failures Robot]

10 failures in 653 pushes (0.015 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 5
* mozilla-central: 3
* mozilla-inbound: 2

Platform breakdown:
* android-4-0-armv7-api16: 10

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1476237&startday=2018-07-16&endday=2018-07-22&tree=trunk