1476352 - Building Fennec fails with crash reporting off

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Gabriel Vîjială [:gabriel-v]]

Steps to reproduce: trigger a clean 'mach build' with crash reporting off (no value set in mozconfig). The build fails with the message:


 0:35.59 /Users/tudor-gabriel/repos/mozilla-unified-2/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashHandler.java:307: error: cannot
find symbol
 0:35.59                 CrashReporterService.enqueueWork(context, intent);
 0:35.59                 ^
 0:35.59   symbol:   variable CrashReporterService
 0:35.59   location: class CrashHandler


This is because CrashReporterService.java is excluded from the sourceSet here:

https://searchfox.org/mozilla-central/rev/6f86cc3479f80ace97f62634e2c82a483d1ede40/mobile/android/geckoview/build.gradle#143

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1476352 - Building Fennec fails with crash reporting off;

Review commit: https://reviewboard.mozilla.org/r/257800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257800/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8992969 [details]
Bug 1476352 - Building Fennec fails with crash reporting off;

https://reviewboard.mozilla.org/r/257800/#review264738

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b694e11fc7ed
Building Fennec fails with crash reporting off; r=jchen

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b694e11fc7ed

Comment 6

[:sdaswani]

petru, you don't need a review here, right? if so you can close the associated mozreview?