1476462 - Ensure "contain" isn't animatable

Status: RESOLVED DUPLICATE of bug 1474317

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Daniel Holbert [:dholbert] (PTO until 2/24)]

heycam says that the CSS Working Group resolved that the "contain" property shoudln't be animatable.  We should make sure our implementation adheres to this.

Comment 1

[Daniel Holbert [:dholbert] (PTO until 2/24)]

Attachment: testcase 1

Comment 2

[Hiroyuki Ikezoe (:hiro)]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> heycam says that the CSS Working Group resolved that the "contain" property
> shoudln't be animatable.

FYI. https://github.com/w3c/csswg-drafts/issues/2737#issuecomment-402574750

Comment 3

[Daniel Holbert [:dholbert] (PTO until 2/24)]

I think this is as simple as changing...
  animation_value_type="discrete",
...to:
  animation_value_type="none",

...at this spot in in this file:
https://dxr.mozilla.org/mozilla-central/rev/085cdfb90903d4985f0de1dc7786522d9fb45596/servo/components/style/properties/longhands/box.mako.rs#588-595

...but we should try that out to be sure.

Comment 4

[Daniel Holbert [:dholbert] (PTO until 2/24)]

(hiro, if you can confirm whether there are any code changes we'll need beyond comment 3, please chime in :)  I suspect you're one of the people who would know.)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

That code change should be enough.

See also https://hg.mozilla.org/mozilla-central/rev/8e815e6e442be7255528d81891cc70401e3f07ce for relevant tests that you may need to modify.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

If you or somebody else want to fix bug 1474317 while at it it'd be nice as well! Otherwise I'll get to it later this week.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Yeah, it would be nice to fix bug 14744317 altogether.

Flipping animation_value_type is enough to do, we also have to drop the properties in testing/web-platform/tests/web-animations/animation-model/animation-types/property-list.js . Thanks!