1476531 - Tweak the animation timing on the tracking protection shield animation

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Johann Hofmann [:johannh]]

Amy had a few suggestions to tweak the new TP shield animation:

- Make the main shield animation (sans fade-out) a little faster
- Make the shield stay purple for 0.2s before fading out

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1476531 - Tweak the animation timing on the tracking protection shield animation. r=nhnt11

Comment 2

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d013ae2ee6aa46de9521347a576d1bcc471612c5

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9002008 [details]
Bug 1476531 - Tweak the animation timing on the tracking protection shield animation. r=nhnt11

Nihanth Subramanya [:nhnt11] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8aa36c4082b2
Tweak the animation timing on the tracking protection shield animation. r=nhnt11

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8aa36c4082b2

Comment 6

[Tim Nguyen :ntim]

Recommenting here as you might have missed the Phabricator comment:

Note that you could have removed the fill property from the 50% blocks.

Comment 7

[Johann Hofmann [:johannh]]

Ah, right, not just the fill-opacity. I missed that, I can make a good first bug...

Thanks!

Comment 8

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this issue is fixed, I verified using Fx 63.0b7, on Windows 10 x64, mac 10.14 and Ubuntu 14.04 LTS x 64.