1476695 - Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity

Status: RESOLVED FIXED

(Core :: Web Audio, enhancement, P2)

Comment 1

[Paul Adenot (:padenot)]

This changed in [0].

[0]: https://github.com/WebAudio/web-audio-api/pull/1359

Comment 2

[Paul Adenot (:padenot)]

Some background: https://github.com/WebAudio/web-audio-api/pull/1359#issuecomment-406036328

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1476695 - Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity.

Review commit: https://reviewboard.mozilla.org/r/257914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257914/

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1476695 - Update wpt expectations.

Review commit: https://reviewboard.mozilla.org/r/257916/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257916/

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 8993084 [details]
Bug 1476695 - Update wpt expectations.

https://reviewboard.mozilla.org/r/257916/#review264912

::: testing/web-platform/meta/webaudio/the-audio-api/the-constantsourcenode-interface/constant-source-basic.html.ini:11
(Diff revision 1)
>    [# AUDIT TASK RUNNER FINISHED: 3 out of 3 tasks were failed.]
>      expected: FAIL
> +
> +  [# AUDIT TASK RUNNER FINISHED: 1 out of 3 tasks were failed.]
> +    expected: FAIL

Please remove the 3 out of 3 tasks were failed line as that has now been replaced.

https://bugzilla.mozilla.org/show_bug.cgi?id=1474463

Comment 6

[Karl Tomlinson (:karlt)]

Comment on attachment 8993083 [details]
Bug 1476695 - Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity.

https://reviewboard.mozilla.org/r/257914/#review264914

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8993084 [details]
Bug 1476695 - Update wpt expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/257916/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30f6da1b0aba
Return minimum and maximum 32bits float for AudioParam.{minValue,maxValue} that used to return infinity. r=karlt
https://hg.mozilla.org/integration/autoland/rev/1ae4395e7cf7
Update wpt expectations. r=karlt

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/30f6da1b0aba
https://hg.mozilla.org/mozilla-central/rev/1ae4395e7cf7

Comment 11

[Eric Shepherd [:sheppy]]

Documentation updated:

https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode/offset
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/value
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/minValue
https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/maxValue

Also added a mention to Firefox 63 for developers.